doc: update "who to cc in issues" chart by Fishrock123 · Pull Request #6694 · nodejs/node

Fishrock123 · 2016-05-11T16:42:50Z

Checklist

documentation is changed or added
the commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

See #6655

@nodejs/collaborators please let us know if you think you should be listed here or not.

addaleax · 2016-05-11T16:44:30Z

doc/onboarding-extras.md

@trevnorris ∈ @nodejs/buffer :)

mscdex · 2016-05-11T16:48:03Z

doc/onboarding-extras.md

s/@mscdex//

I am already in in nodejs/http

As is @indutny ... I can add @bnoordhuis to it right now also

jasnell · 2016-05-11T16:53:04Z

doc/onboarding-extras.md

I have created the nodejs/fs team with these initial members

jasnell · 2016-05-11T17:02:41Z

doc/onboarding-extras.md

wrong line for nodejs/http

(we store it as deps/cares)

Hopefully we can use this as part of the bot at some stage?

I've been thinking we could re-use the bot's logic for resolving PR labels, for /cc-ing as well. Who to /cc for which label could be read from this file.

orangemocha · 2016-05-12T14:44:20Z

We could add @nodejs/platform-windows for tools/msvs/* (mostly for the MSI).

Trott · 2016-05-12T18:10:49Z

LGTM once the c-ares/http error on line 25 is fixed and nodejs/http is added to line 26 (http-parser).

IMO, other nits/comments can be addressed now or in subsequent PRs. Fine by me either way.

ronkorving · 2016-05-17T03:27:41Z

Feel free to add me to the fs group.

eljefedelrodeodeljefe · 2016-05-25T12:37:53Z

@Fishrock123 ping

MylesBorins · 2016-06-06T22:32:14Z

@Fishrock123 want me to take this over?

Fishrock123 · 2016-06-17T20:15:58Z

Updated, LGTEveryone?

MylesBorins · 2016-06-17T20:41:23Z

LGTM

Trott · 2016-06-17T21:00:56Z

LGTM

addaleax · 2016-06-22T22:03:45Z

LGTM

Trott · 2016-06-22T22:20:47Z

@RReverser Looks like this PR already updates the who-to-cc for buffer to the correct group.

RReverser · 2016-06-22T22:51:42Z

@Trott. Great! LGTM.

Refs: nodejs#6655 PR-URL: nodejs#6694 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ingvar Stepanyan <me@rreverser.com>

Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ingvar Stepanyan <me@rreverser.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 11, 2016

Fishrock123 mentioned this pull request May 11, 2016

Use Teams for the "Who to CC in issues chart" #6655

Closed

addaleax reviewed May 11, 2016
View reviewed changes

doc/onboarding-extras.md Outdated

Copy link

Member

addaleax May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevnorris ∈ @nodejs/buffer :)

Fishrock123 force-pushed the doc/subsystem-teams branch from 0b99265 to 4746b8e Compare May 11, 2016 16:45

mscdex reviewed May 11, 2016
View reviewed changes

Fishrock123 force-pushed the doc/subsystem-teams branch from 4746b8e to 92c48a9 Compare May 11, 2016 16:51

jasnell reviewed May 11, 2016
View reviewed changes

doc/onboarding-extras.md Outdated

Copy link

Member

jasnell May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created the nodejs/fs team with these initial members

Fishrock123 force-pushed the doc/subsystem-teams branch from 92c48a9 to 2c7251b Compare May 11, 2016 17:00

jasnell reviewed May 11, 2016
View reviewed changes

addaleax added the meta Issues and PRs related to the general management of the project. label May 17, 2016

Fishrock123 force-pushed the doc/subsystem-teams branch from 2c7251b to 2e99bbd Compare June 17, 2016 20:15

Fishrock123 force-pushed the doc/subsystem-teams branch from 2e99bbd to 451c1f8 Compare June 17, 2016 20:20

doc: update "who to cc in issues" chart

f5cddad

Refs: nodejs#6655 PR-URL: nodejs#6694 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ingvar Stepanyan <me@rreverser.com>

Fishrock123 force-pushed the doc/subsystem-teams branch from 451c1f8 to f5cddad Compare June 24, 2016 12:57

Fishrock123 merged commit f5cddad into nodejs:master Jun 24, 2016

phillipj mentioned this pull request Jun 24, 2016

Add comment cc-ing teams/devs in issues nodejs/github-bot#49

Closed

Fishrock123 mentioned this pull request Jun 27, 2016

Propose v6.3.0 #7441

Merged

Fishrock123 mentioned this pull request Jul 5, 2016

Propose v6.3.0 (v2) #7550

Merged

MylesBorins mentioned this pull request Jul 11, 2016

Audit commits not found on v4.x-staging #7661

Closed

MylesBorins added the land-on-v4.x label Jul 11, 2016

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

Uh oh!

Conversation

Fishrock123 commented May 11, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

addaleax May 11, 2016

Choose a reason for hiding this comment

Uh oh!

mscdex May 11, 2016

Choose a reason for hiding this comment

Uh oh!

jasnell May 11, 2016

Choose a reason for hiding this comment

Uh oh!

jasnell May 11, 2016

Choose a reason for hiding this comment

Uh oh!

jasnell May 11, 2016

Choose a reason for hiding this comment

Uh oh!

jbergstroem May 12, 2016

Choose a reason for hiding this comment

Uh oh!

phillipj May 12, 2016

Choose a reason for hiding this comment

Uh oh!

orangemocha commented May 12, 2016

Uh oh!

Trott commented May 12, 2016

Uh oh!

ronkorving commented May 17, 2016

Uh oh!

eljefedelrodeodeljefe commented May 25, 2016

Uh oh!

MylesBorins commented Jun 6, 2016

Uh oh!

Fishrock123 commented Jun 17, 2016

Uh oh!

MylesBorins commented Jun 17, 2016

Uh oh!

Trott commented Jun 17, 2016

Uh oh!

addaleax commented Jun 22, 2016

Uh oh!

Trott commented Jun 22, 2016

Uh oh!

RReverser commented Jun 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants