Closed
Conversation
Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows.
Trott
added
test
Member
Author
Member
|
Appreciate it! Use of the labels really helps save time. |
Contributor
|
cc @joaocgreis |
Member
Author
|
#6555 landed, which means this can land, so I'm removing the |
Member
Author
Member
Author
|
Single test failure in CI looks unrelated. Opened an "investigate flaky test" issue for it. Re-running CI: https://ci.nodejs.org/job/node-test-pull-request/2521/ |
Member
Author
|
CI is green. /bump @nodejs/collaborators |
Contributor
|
LGTM, but I'm not comfortable being the only sign off on Python code :-) |
Member
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 6, 2016
Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows. PR-URL: nodejs#6559 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
Author
|
Landed in 5d0b1f4 |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows. PR-URL: #6559 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Contributor
|
@Trott lts? |
Member
Author
|
@thealphanerd Yes. |
Contributor
|
@Trott does not land cleanly.. feel free to backport |
Member
Author
|
It's not essential. I'm OK with leaving it out. |
3 tasks
aqrln
pushed a commit
that referenced
this pull request
Apr 9, 2017
* Since #6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: #12262 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
* Since nodejs#6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: nodejs#12262 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
* Since #6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: #12262 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
* Since #6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: #12262 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* Since nodejs/node#6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: nodejs/node#12262 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Add
known_issuestests tomake testandmake test-citargets andtheir equivalents on Windows.
This should not land until #6555 lands first.(#6555 landed, woot.)/cc @cjihrig @Fishrock123 @nodejs/testing ... and whoever the Python folks are who can tell me if I'm Doing It Wrong in
testcfg.py... @thefourtheye? @bnoordhuis? @jbergstroem? Someone else?