Create new branch for V8 5.1#6482
Conversation
|
@misterdjules Do you have any ideas about the dtrace compile issue on SmartOS: https://ci.nodejs.org/job/node-test-commit-smartos/2266/nodes=smartos14-32/console |
|
@misterdjules For reference: v8/v8@9dcd085 and v8/v8@cbd91c5. The commit log mentions @ofrobots You might want to float this patch for now to get past the build error: diff --git a/configure b/configure
index 03a889d..8839e12 100755
--- a/configure
+++ b/configure
@@ -736,7 +736,7 @@ def configure_node(o):
if flavor in ('solaris', 'mac', 'linux', 'freebsd'):
use_dtrace = not options.without_dtrace
# Don't enable by default on linux and freebsd
- if flavor in ('linux', 'freebsd'):
+ if flavor in ('linux', 'freebsd', 'solaris'):
use_dtrace = options.with_dtrace
if flavor == 'linux':I've tried restarting the armv8 build job but the CI is very, very slow right now. |
|
Temporarily disabled dtrace by default on solaris, as per suggestion from @bnoordhuis. New CI: https://ci.nodejs.org/job/node-test-pull-request/2456/. |
|
For my own gratification, CI run on linuxOne: https://ci.nodejs.org/job/node-test-commit-linuxone-mdawson/nodes=rhel72-s390x/22/, all green :) |
|
It turns out that
I have updated the PR with the patch from @davepacheco, and removed the temporary fix. New CI: https://ci.nodejs.org/job/node-test-pull-request/2461/ |
|
CI is green. @nodejs/v8 please review. |
|
Can you either use the full URL ( |
Pick up the latest branch-head for V8 5.1. This branch brings in improved language support and performance improvements. For full details: http://v8project.blogspot.com/2016/04/v8-release-51.html * Picks up the latest branch head for 5.1 [1] * Edit v8 gitignore to allow trace_event copy * Update V8 DEP trace_event as per deps/v8/DEPS [2] [1] https://chromium.googlesource.com/v8/v8.git/+/f81c34e [2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/c8c8665c2deaf1cc749d9f8e153256d4f67bf1b8 PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 improved the error message for illegal token in v8/v8@879b617b. This breaks the recoverable error handling in repl. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
* Changes to messages. * V8 enabled proxy support by default. The --harmony_proxies flag is now gone. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks, fixed commit message, and landed on |
V8 improved the error message for illegal token in v8/v8@879b617b. This breaks the recoverable error handling in repl. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
* Changes to messages. * V8 enabled proxy support by default. The --harmony_proxies flag is now gone. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 5.1 changes the layout of stack frames. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 improved the error message for illegal token in v8/v8@879b617b. This breaks the recoverable error handling in repl. Ref: #6482 PR-URL: #7016 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
* Changes to messages. * V8 enabled proxy support by default. The --harmony_proxies flag is now gone. PR-URL: #6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 5.1 changes the layout of stack frames. PR-URL: #6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 improved the error message for illegal token in v8/v8@879b617b. This breaks the recoverable error handling in repl. Ref: nodejs#6482 PR-URL: nodejs#7016 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
* Changes to messages. * V8 enabled proxy support by default. The --harmony_proxies flag is now gone. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 5.1 changes the layout of stack frames. PR-URL: nodejs#6482 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Checklist
Affected core subsystem(s)
deps, test
Description of change
deps: upgrade to V8 5.1.281.24 [vee-eight-5.1]
Pick up the latest branch-head for V8 5.1. This branch brings in
improved language support and performance improvements. For full
details: http://v8project.blogspot.com/2016/04/v8-release-51.html
[1] v8/v8@f81c34e
[2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/c8c8665c2deaf1cc749d9f8e153256d4f67bf1b8
R=@nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/2440/