doc: update authors file by jasnell · Pull Request #6373 · nodejs/node

jasnell · 2016-04-25T15:01:55Z

Affected core subsystem(s)

Description of change

Update the authors file for v6 ... ~119 new contributors since this was last updated!

addaleax · 2016-04-25T15:14:26Z

AUTHORS

@jasnell You can remove this line, I feel fine being listed once, but thanks. 😄

jasnell · 2016-04-25T15:18:58Z

done! removed a couple other duplicates that I noticed as well

santigimeno · 2016-04-25T15:26:12Z

AUTHORS

You can remove this entry. I'm already added with a different email, I committed only once with this by mistake.

MylesBorins · 2016-04-25T15:37:14Z

@jasnell I think the dupes can be added to https://github.com/nodejs/node/blob/master/.mailmap

ChALkeR · 2016-04-25T15:38:33Z

AUTHORS

Any reason for moving duplicates to the bottom? The list should be ordered, afaik, and this commit actually moves some contributors down.

jasnell · 2016-04-25T15:55:26Z

Thanks! Additional cleanups pushed. Keep the fixes coming! :-)

ChALkeR · 2016-04-25T16:04:52Z

AUTHORS

Same: moved for some reason to Stefan Budeanu <stefanbu@ca.ibm.com> a bit lower.

ChALkeR · 2016-04-26T06:39:48Z

AUTHORS

GitHub profile says Graham Fairweather. Also, the email is incorrect (misses the .com).
/cc @Xotic750

benjamingr · 2016-04-26T07:50:21Z

AUTHORS

Should probably be Florian Margaine? @ralt

I like the capitalized (and not uppercased) version better, but I don't really care either way tbh

@jasnell ~~That means that this line should be fixed to Florian Margaine.~~
Ah, sorry, it's already fixed =). Thanks!

jasnell · 2016-04-26T15:42:38Z

Updated and squashed. Will be landing this shortly. Last call for additional edits.

ChALkeR · 2016-04-26T15:49:47Z

AUTHORS

/cc @suryagh. Is that the preferred name?

@ChALkeR yes, thank you.

jasnell · 2016-04-26T16:24:34Z

Will be landing this in about twenty minutes or so

ChALkeR · 2016-04-26T16:38:20Z

LGTM

ChALkeR · 2016-04-26T16:42:36Z

Wait, give me two more minutes.

ChALkeR · 2016-04-26T16:43:00Z

AUTHORS

Steve Mao <maochenyan@msn.com>
Steve Mao <maochenyan@gmail.com>

Duplicates?

ChALkeR · 2016-04-26T16:48:14Z

@jasnell I highlighted some new entries that are likely duplicates.
Otherwise, LGTM. Actually, it's LGTM even with the duplicates — we can sort those out later.
There are some older duplicates already, e.g. @bnoordhuis is mentioned two times.

~116 new contributors since this was last updated!

jasnell · 2016-04-26T16:49:51Z

OK... updated and landing!

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

jasnell · 2016-04-26T16:51:27Z

Landed in a026cd0

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

jasnell added the meta Issues and PRs related to the general management of the project. label Apr 25, 2016

jasnell added this to the 6.0.0 milestone Apr 25, 2016

addaleax reviewed Apr 25, 2016
View reviewed changes

AUTHORS Outdated

Copy link

Member

addaleax Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell You can remove this line, I feel fine being listed once, but thanks. 😄

santigimeno reviewed Apr 25, 2016
View reviewed changes

AUTHORS Outdated

Copy link

Member

santigimeno Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this entry. I'm already added with a different email, I committed only once with this by mistake.

ChALkeR reviewed Apr 25, 2016
View reviewed changes

AUTHORS Outdated

Copy link

Member

ChALkeR Apr 25, 2016 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same: moved for some reason to Stefan Budeanu <stefanbu@ca.ibm.com> a bit lower.

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

ChALkeR reviewed Apr 26, 2016
View reviewed changes

AUTHORS Outdated

Copy link

Member

ChALkeR Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub profile says Graham Fairweather. Also, the email is incorrect (misses the .com).
/cc @Xotic750

benjamingr reviewed Apr 26, 2016
View reviewed changes

jasnell force-pushed the update-authors branch from d6a9faf to e70f321 Compare April 26, 2016 15:41

ChALkeR reviewed Apr 26, 2016
View reviewed changes

jasnell force-pushed the update-authors branch from e70f321 to 841caf9 Compare April 26, 2016 16:48

doc: update authors

62d4029

~116 new contributors since this was last updated!

jasnell force-pushed the update-authors branch from 841caf9 to 62d4029 Compare April 26, 2016 16:49

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: update authors

a026cd0

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

jasnell closed this Apr 26, 2016

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: update authors

547a6fe

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jun 1, 2016

doc: update authors

2374a58

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added dont-land-on-v4.x and removed dont-land-on-v4.x labels Jun 1, 2016

MylesBorins mentioned this pull request Jun 24, 2016

v4.4.7 proposal #7395

Merged

MylesBorins pushed a commit that referenced this pull request Jun 24, 2016

doc: update authors

e28598b

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jun 24, 2016

doc: update authors

40d52db

~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

ChALkeR mentioned this pull request Aug 30, 2016

doc: update authors list again #8346

Closed

2 tasks

Uh oh!

Conversation

jasnell commented Apr 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Affected core subsystem(s)

Description of change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Apr 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Apr 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Apr 25, 2016

Uh oh!

ChALkeR Apr 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ralt Apr 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChALkeR Apr 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Apr 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Apr 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChALkeR commented Apr 26, 2016

Uh oh!

ChALkeR commented Apr 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChALkeR commented Apr 26, 2016

Uh oh!

jasnell commented Apr 26, 2016

Uh oh!

jasnell commented Apr 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

jasnell commented Apr 25, 2016 •

edited

Loading

ChALkeR Apr 25, 2016 •

edited

Loading

ralt Apr 26, 2016 •

edited

Loading

ChALkeR Apr 26, 2016 •

edited

Loading

jasnell commented Apr 26, 2016 •

edited

Loading