crypto: fix error in deprecation message

[Trott]

Checklist

• tests and code linting passes
• a test and/or benchmark is included
• the commit message follows commit guidelines

Affected core subsystem(s)

crypto test

Description of change

The deprecation message for crypto.Credentials says to use
tls.createSecureContext but the correct property to use is
tls.SecureContext().

Fix the deprecation message and add a test that checks the mappings of
deprecated properties and their warning messages.

@nodejs/crypto

[jasnell]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2403/

[Trott]

CI failures are one buildbot failure and the current problematic tick processor issue on OS X. Unrelated, of course.

[Trott]

Landed in 296bfd2

[MylesBorins]

@Trott lts?

[Trott]

@thealphanerd Yes.

[MylesBorins]

@Trott test failure on v4.x-staging, can you manually backport?

edit: please include all original meta data

[Trott]

@thealphanerd Is the test failing because warning events don't exist in v4 or something like that? (Link to failing test?)

[MylesBorins]

Path: parallel/test-crypto-deprecated
Mismatched <anonymous> function calls. Expected 2, actual 0.
    at Object.<anonymous> (/Users/thealphanerd/code/node/v4.x/test/parallel/test-crypto-deprecated.js:12:30)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:139:18)
    at node.js:968:3
(node) crypto.Credentials is deprecated. Use tls.SecureContext instead.
(node) crypto.createCredentials is deprecated. Use tls.createSecureContext instead.

[Trott]

This depends on process.emitWarning() which will not land in LTS.

So the test needs to be re-written for LTS.

Or we could choose not to land.

Or you could just land the deprecation message text change and not land the test.

[MylesBorins]

@Trott I'm leaving this as don't land for now. Please feel free to open a new PR