test: Add zlib close-after-error regression test#6270
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test: Add zlib close-after-error regression test#6270addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
added
zlib
4 tasks
Add a regression test based on the report in nodejs#6034.
addaleax
force-pushed
the
zlib-6034-regression-test
branch
from
ba573bb to
96f04d6
Compare
Member
Author
Contributor
|
LGTM. CI is green. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
Wanna go ahead and land this one @addaleax ? :-) |
Member
Author
|
@jasnell Sure, I just didn’t really see any reason not to wait the recommended time so that everyone can point out the gazillion style nits I usually produce 😉 |
Member
Author
|
Landed in f8e507e. |
Member
|
;-) no style nits in this one! For really small commits like this (tests, docs, lints, etc), if there's obvious consensus then it's usually ok to land a bit sooner than the 48 hours. |
This was referenced Apr 21, 2016
Closed
Closed
Contributor
Member
Author
|
@thealphanerd Should be included together with #5982, yes. |
Contributor
|
thanks for the swift response, and for all the awesome work you've been putting in lately!!! |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Add a regression test based on the report in nodejs#6034. PR-URL: nodejs#6270 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
zlib, test
Description of change
Add a regression test based on the report in #6034. The bug itself has been fixed in #5982.