doc: fix node-config-schema

[ChALkeR]

Fixes #61595

1. minItems was used incorrectly
2. added "required": [], to explicitly document that there are no required properties (which allows running in requireValidation mode which also ensures that no props are non-typed)

It now passes in:

1. require('@exodus/schemasafe').validator(require('../../doc/node-config-schema.json')
2. require('@exodus/schemasafe').validator(require('../../doc/node-config-schema.json', { requireValidation: true })

Strings are still not validated

[nodejs-github-bot]

Review requested:

• @nodejs/config

[marco-ippolito]

The schema is automaticly generated so this change will be overwritten.

[ChALkeR]

@marco-ippolito The generator is wrong and has to be fixed then.

[ChALkeR]

@marco-ippolito updated.

[marco-ippolito]

This is where the schema is generated:
https://github.com/nodejs/node/blob/main/tools%2Fdoc%2Fgenerate-json-schema.mjs

[ChALkeR]

@marco-ippolito 🤦🏻 i forgot to add the last required: [] line to the generator commit. Please re-review, that's the only change since the last review.

---

There is now only unrelated difference between what require('internal/options').generateConfigJsonSchema() outputs and the file in doc/:

diff --git a/doc/node-config-schema.json b/doc/node-config-schema.json
index ad1c4440108..5811cf8892d 100644
--- a/doc/node-config-schema.json
+++ b/doc/node-config-schema.json
@@ -164,9 +164,6 @@
         "experimental-print-required-tla": {
           "type": "boolean"
         },
-        "experimental-quic": {
-          "type": "boolean"
-        },
         "experimental-repl-await": {
           "type": "boolean"
         },
@@ -351,6 +348,9 @@
             }
           ]
         },
+        "require-module": {
+          "type": "boolean"
+        },
         "secure-heap": {
           "type": "number"
         },

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (e155415) to head (40bfdac).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/options.js	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61596      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files         672      673       +1     
  Lines      203755   203897     +142     
  Branches    39167    39189      +22     
==========================================
+ Hits       182922   183044     +122     
- Misses      13164    13183      +19     
- Partials     7669     7670       +1     

Files with missing lines	Coverage Δ
lib/internal/options.js	46.59% <0.00%> (-1.65%)	⬇️

... and 67 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71139/

[gurgunday]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71141/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71143/

[nodejs-github-bot]

Landed in 6c44d31