lib: use bracket notation instead of String.prototype.startWith for locks#61492
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Jan 29, 2026
Merged
Conversation
Use StringPrototypeStartsWith from primordials instead of String.prototype.startsWith to prevent prototype pollution. Refs: nodejs#59699
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61492 +/- ##
==========================================
- Coverage 89.82% 89.78% -0.05%
==========================================
Files 667 672 +5
Lines 203693 203809 +116
Branches 39163 39190 +27
==========================================
+ Hits 182963 182980 +17
- Misses 13061 13167 +106
+ Partials 7669 7662 -7
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Jan 23, 2026
Collaborator
ljharb
reviewed
Jan 23, 2026
cjihrig
approved these changes
Jan 24, 2026
Collaborator
Co-authored-by: Jordan Harband <ljharb@gmail.com>
String.prototype.startWith for locks
gurgunday
reviewed
Jan 26, 2026
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Collaborator
Collaborator
gurgunday
approved these changes
Jan 29, 2026
Collaborator
|
Landed in 784ca7b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use StringPrototypeStartsWith from primordials instead of String.prototype.startsWith to prevent prototype pollution.