zlib: add CHECK to validate fast path input#61175
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 30, 2025
Merged
zlib: add CHECK to validate fast path input#61175nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61175 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 703 703
Lines 208546 208599 +53
Branches 40217 40231 +14
=======================================
+ Hits 184634 184690 +56
+ Misses 15926 15911 -15
- Partials 7986 7998 +12
🚀 New features to boost your workflow:
|
Renegade334
reviewed
Dec 26, 2025
cjihrig
approved these changes
Dec 26, 2025
github-actions
bot
removed
the
request-ci
Collaborator
mcollina
force-pushed
the
fix-zlib-crc32-fast-path-validation
branch
from
958ba9c to
c2aaa42
Compare
mcollina
changed the title
Renegade334
approved these changes
Dec 27, 2025
lpinca
approved these changes
Dec 27, 2025
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ce2ec3d |
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #61175 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 12, 2026
PR-URL: #61175 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #61175 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 19, 2026
PR-URL: #61175 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#61175 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing CHECK in FastCRC32 to match the slow path.