[v24.x backport] repl: move completion logic to internal module#61046
Merged
aduh95 merged 1 commit intonodejs:v24.x-stagingfrom Feb 3, 2026
Merged
[v24.x backport] repl: move completion logic to internal module#61046aduh95 merged 1 commit intonodejs:v24.x-stagingfrom
aduh95 merged 1 commit intonodejs:v24.x-stagingfrom
Conversation
nodejs-github-bot
added
needs-ci
dario-piotrowicz
approved these changes
Dec 13, 2025
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @targos! 🫶
targos
changed the title
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
avivkeller
added
author ready
avivkeller
approved these changes
Jan 10, 2026
github-actions
bot
removed
the
request-ci
Collaborator
marco-ippolito
force-pushed
the
v24.x-staging
branch
from
d4dceb9 to
2358296
Compare
PR-URL: nodejs#59889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
force-pushed
the
backport-repl-v24
branch
from
3961e22 to
e781d88
Compare
Member
Author
|
Simple rebase without conflicts. |
Collaborator
Collaborator
Contributor
|
Landed in 2d6309f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59889