util: limit inspect to only show own properties by BridgeAR · Pull Request #61032 · nodejs/node

BridgeAR · 2025-12-12T13:25:23Z

Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling.

As drive-by I changed an array to a set for faster lookup in assert.

Fixes: #60717
Closes: #60724

codecov · 2025-12-12T14:21:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (14f02fc) to head (eee56d6).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61032      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.01%     
==========================================
  Files         703      703              
  Lines      208538   208546       +8     
  Branches    40214    40219       +5     
==========================================
- Hits       184615   184604      -11     
- Misses      15921    15968      +47     
+ Partials     8002     7974      -28

Files with missing lines	Coverage Δ
lib/internal/util/inspect.js	`99.63% <100.00%> (ø)`

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/internal/assert/assertion_error.js

Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling. Fixes: nodejs#60717 Closes: nodejs#60724

lib/internal/assert/assertion_error.js

nodejs-github-bot · 2025-12-19T16:55:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70523/

nodejs-github-bot · 2025-12-20T01:37:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70539/

nodejs-github-bot · 2025-12-22T11:27:17Z

Commit Queue failed

- Loading data for nodejs/node/pull/61032 ✔ Done loading data for nodejs/node/pull/61032 ----------------------------------- PR info ------------------------------------ Title util: limit inspect to only show own properties (#61032) Author Ruben Bridgewater <ruben@bridgewater.de> (@BridgeAR) Branch BridgeAR:BridgeAR/2025-12-12-only-inspect-own-properties -> nodejs:main Labels assert, util, console, author ready, needs-ci, commit-queue-squash Commits 2 - util: limit inspect to only show own properties - fixup! Committers 1 - Ruben Bridgewater <ruben.bridgewater@datadoghq.com> PR-URL: https://github.com/nodejs/node/pull/61032 Fixes: https://github.com/nodejs/node/issues/60717 Fixes: https://github.com/nodejs/node/pull/60724 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61032 Fixes: https://github.com/nodejs/node/issues/60717 Fixes: https://github.com/nodejs/node/pull/60724 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Dec 2025 13:25:23 GMT ✔ Approvals: 2 ✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/61032#pullrequestreview-3586247028 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61032#pullrequestreview-3580403058 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-12-20T01:37:30Z: https://ci.nodejs.org/job/node-test-pull-request/70539/ - Querying data for job/node-test-pull-request/70539/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61032 From https://github.com/nodejs/node * branch refs/pull/61032/merge -> FETCH_HEAD ✔ Fetched commits as d7e4108bc1be..eee56d642aee -------------------------------------------------------------------------------- Auto-merging lib/internal/util/inspect.js [main 04e7a6fb99] util: limit inspect to only show own properties Author: Ruben Bridgewater <ruben.bridgewater@datadoghq.com> Date: Fri Dec 12 13:24:26 2025 +0100 3 files changed, 50 insertions(+), 2 deletions(-) [main fe73d78442] fixup! Author: Ruben Bridgewater <ruben.bridgewater@datadoghq.com> Date: Mon Dec 15 22:58:30 2025 +0100 1 file changed, 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting to fixup everything into first commit. [main f01508c6bd] util: limit inspect to only show own properties Author: Ruben Bridgewater <ruben.bridgewater@datadoghq.com> Date: Fri Dec 12 13:24:26 2025 +0100 2 files changed, 49 insertions(+), 2 deletions(-) ⚠ Found Fixes: https://github.com/nodejs/node/issues/60717, skipping.. --------------------------------- New Message ---------------------------------- util: limit inspect to only show own properties

Error's cause and errors properties would be visible even if these
were not own properties. This is changed to align with all other
parts of the inspect handling.

Fixes: #60717
Closes: #60724
PR-URL: #61032
Fixes: #60724
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

[main 25cb62cb7f] util: limit inspect to only show own properties
Author: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
Date: Fri Dec 12 13:24:26 2025 +0100
2 files changed, 49 insertions(+), 2 deletions(-)
✖ 25cb62cb7f70471de9b01664032e318b8458de94
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 5:7 Valid fixes URL. fixes-url
✖ 8:7 Pull request URL must reference a comment or discussion. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 7:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/20430516616

aduh95 · 2025-12-22T13:06:16Z

Landed in 26b7fd2

mnahkies · 2026-01-02T09:52:31Z

@aduh95 is this likely to get cherry picked into v24? It's a bit of a blocker for us upgrading from v22 -> v24

`Error`'s `cause` and `errors` properties would be visible even if these were not own properties. This is changed to align with all other parts of the `inspect` handling. Fixes: #60717 PR-URL: #61032 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

`Error`'s `cause` and `errors` properties would be visible even if these were not own properties. This is changed to align with all other parts of the `inspect` handling. Fixes: nodejs#60717 PR-URL: nodejs#61032 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

BridgeAR added util Issues and PRs related to the built-in util module. console Issues and PRs related to the console subsystem. labels Dec 12, 2025

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Dec 12, 2025

ljharb approved these changes Dec 12, 2025

View reviewed changes

BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 12, 2025

aduh95 reviewed Dec 12, 2025

View reviewed changes

lib/internal/assert/assertion_error.js Outdated Show resolved Hide resolved

util: limit inspect to only show own properties

29620d2

Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling. Fixes: nodejs#60717 Closes: nodejs#60724

BridgeAR force-pushed the BridgeAR/2025-12-12-only-inspect-own-properties branch from e0f773f to 29620d2 Compare December 15, 2025 11:50

aduh95 reviewed Dec 15, 2025

View reviewed changes

lib/internal/assert/assertion_error.js Outdated Show resolved Hide resolved

aduh95 approved these changes Dec 15, 2025

View reviewed changes

fixup!

eee56d6

BridgeAR requested review from aduh95 and ljharb December 15, 2025 21:58

aduh95 approved these changes Dec 15, 2025

View reviewed changes

ljharb approved these changes Dec 17, 2025

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025

BridgeAR added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 22, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 22, 2025

aduh95 merged commit 26b7fd2 into nodejs:main Dec 22, 2025
70 of 74 checks passed

github-actions bot mentioned this pull request Jan 16, 2026

2026-01-19, Version 25.4.0 (Current) #61400

Merged

github-actions bot mentioned this pull request Feb 3, 2026

2026-02-10, Version 24.13.1 'Krypton' (LTS) #61661

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

util: limit inspect to only show own properties#61032

util: limit inspect to only show own properties#61032
aduh95 merged 2 commits intonodejs:mainfrom
BridgeAR:BridgeAR/2025-12-12-only-inspect-own-properties

BridgeAR commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 19, 2025

Uh oh!

nodejs-github-bot commented Dec 20, 2025

Uh oh!

nodejs-github-bot commented Dec 22, 2025

Fixes: #60717
Closes: #60724
PR-URL: #61032
Fixes: #60724
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Uh oh!

Uh oh!

aduh95 commented Dec 22, 2025

Uh oh!

mnahkies commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

BridgeAR commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 19, 2025

Uh oh!

nodejs-github-bot commented Dec 20, 2025

Uh oh!

nodejs-github-bot commented Dec 22, 2025

Fixes: #60717 Closes: #60724 PR-URL: #61032 Fixes: #60724 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Uh oh!

Uh oh!

aduh95 commented Dec 22, 2025

Uh oh!

mnahkies commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 12, 2025 •

edited

Loading

Fixes: #60717
Closes: #60724
PR-URL: #61032
Fixes: #60724
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>