url: add fast path to getPathFromURL decoder#60749
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Dec 30, 2025
Merged
url: add fast path to getPathFromURL decoder#60749nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60749 +/- ##
==========================================
+ Coverage 88.54% 88.55% +0.01%
==========================================
Files 703 703
Lines 208222 208256 +34
Branches 40140 40152 +12
==========================================
+ Hits 184360 184420 +60
+ Misses 15882 15836 -46
- Partials 7980 8000 +20
🚀 New features to boost your workflow:
|
aduh95
reviewed
Nov 16, 2025
anonrig
approved these changes
Nov 23, 2025
This comment was marked as outdated.
This comment was marked as outdated.
avivkeller
approved these changes
Dec 28, 2025
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/70615/ Results |
Collaborator
|
Landed in 6e7a501 |
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #60749 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Jan 12, 2026
PR-URL: #60749 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Aviv Keller <me@aviv.sh>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #60749 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Jan 19, 2026
PR-URL: #60749 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Aviv Keller <me@aviv.sh>
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#60749 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branch:
main:
The majority of file paths won't need decoding, so this PR avoids calling
decodeURIComponentwhen the path is pure ASCII with no encodings