doc,src,lib: clarify experimental status of Web Storage support#60708
doc,src,lib: clarify experimental status of Web Storage support#60708nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60708 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.02%
==========================================
Files 703 703
Lines 208218 208222 +4
Branches 40140 40137 -3
==========================================
- Hits 184351 184319 -32
- Misses 15862 15900 +38
+ Partials 8005 8003 -2
🚀 New features to boost your workflow:
|
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
Commit Queue failed- Loading data for nodejs/node/pull/60708 ✔ Done loading data for nodejs/node/pull/60708 ----------------------------------- PR info ------------------------------------ Title doc,src,lib: clarify experimental status of Web Storage support (#60708) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:experimental-web-storage -> nodejs:main Labels c++, process, author ready, needs-ci, dont-land-on-v20.x, backport-requested-v22.x, config, backport-requested-v24.x Commits 3 - doc,src,lib: clarify experimental status of Web Storage support - Update doc/api/globals.md - Update doc/api/globals.md Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/60708 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60708 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 13 Nov 2025 21:05:51 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/60708#pullrequestreview-3468018245 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/60708#pullrequestreview-3470218448 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-11-16T14:02:45Z: https://ci.nodejs.org/job/node-test-pull-request/70204/ - Querying data for job/node-test-pull-request/70204/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60708 From https://github.com/nodejs/node * branch refs/pull/60708/merge -> FETCH_HEAD ✔ Fetched commits as 33b1574cbf65..be312f1d8221 -------------------------------------------------------------------------------- Auto-merging doc/api/cli.md [main cd67f3ac95] doc,src,lib: clarify experimental status of Web Storage support Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Nov 13 21:55:21 2025 +0100 5 files changed, 42 insertions(+), 22 deletions(-) [main 92e7991e03] Update doc/api/globals.md Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Fri Nov 14 14:04:20 2025 +0100 1 file changed, 8 insertions(+), 3 deletions(-) [main b6ce41b2bd] Update doc/api/globals.md Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Fri Nov 14 14:05:24 2025 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:2255) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc,src,lib: clarify experimental status of Web Storage supporthttps://github.com/nodejs/node/actions/runs/19407453874 |
|
Landed in 3330e5c |
PR-URL: #60708 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #60708 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #60708 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `25.2.0` -> `25.2.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.2.1`](https://github.com/nodejs/node/releases/tag/v25.2.1): 2025-11-17, Version 25.2.1 (Current), @​aduh95 [Compare Source](nodejs/node@v25.2.0...v25.2.1) This release reverts the spec-compliant behavior of sometimes throwing on `localStorage` access. We received feedback that this change on an experimental API was too breaking for a semver-minor release, so we decided to push it back for Node.js 26.0.0. ##### Commits - \[[`ff89b7b6c7`](nodejs/node@ff89b7b6c7)] - **crypto**: ensure documented RSA-PSS saltLength default is used (Filip Skokan) [#​60662](nodejs/node#60662) - \[[`5316b580eb`](nodejs/node@5316b580eb)] - **deps**: V8: backport [`2e4c5cf`](nodejs/node@2e4c5cf9b112) (Michaël Zasso) [#​60654](nodejs/node#60654) - \[[`ca878bc90e`](nodejs/node@ca878bc90e)] - **doc,src,lib**: clarify experimental status of Web Storage support (Antoine du Hamel) [#​60708](nodejs/node#60708) - \[[`a4dee613fd`](nodejs/node@a4dee613fd)] - ***Revert*** "**lib**: throw from localStorage getter on missing storage path" (Antoine du Hamel) [#​60750](nodejs/node#60750) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This comment was marked as off-topic.
This comment was marked as off-topic.
main notable comment |
ummitsmerogers-droid
left a comment
There was a problem hiding this comment.
Pros (What's Great)
Flexibility & Minimalism: Offers great control, letting you choose your structure and tools.
Speed: Inherits Node.js speed and is fast for building lightweight apps, APIs, and prototypes.
Routing: Powerful and simple routing for handling HTTP requests.
- Middleware: Extensive ecosystem of middleware for adding functionality (auth, logging, etc.).
Huge Community: Vast resources, tutorials, and packages available.
Full-Stack JS: Use JavaScript on both frontend and backend.
Express remains a dominant, effective choice for most Node.js backend needs, especially if you value flexibility and a strong community, but be prepared to build your own structure and manage dependencies, says AltexSoft. I think this works
PR-URL: #60708 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Documentation around Web Storage is kinda all over the place, IMO we're really not making a good job at presenting the experimental aspect of it.