worker: remove not implemented declarations of Worker::CloneParentEnvVars and Worker::SetEnvVars#60655
Conversation
714b656 to
b1b3714
Compare
| uv_loop_t loop_; | ||
| bool loop_init_failed_ = true; | ||
| DeleteFnPtr<IsolateData, FreeIsolateData> isolate_data_; | ||
| const SnapshotData* snapshot_data_ = nullptr; |
There was a problem hiding this comment.
Removed also this one because of error: private field 'snapshot_data_' is not used [-Werror,-Wunused-private-field]
Worker::CloneParentEnvVars and Worker::SetEnvVarsWorker::CloneParentEnvVars and Worker::SetEnvVars
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60655 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 703 703
Lines 208077 208076 -1
Branches 40082 40081 -1
==========================================
- Hits 184252 184237 -15
- Misses 15848 15858 +10
- Partials 7977 7981 +4
🚀 New features to boost your workflow:
|
Commit Queue failed- Loading data for nodejs/node/pull/60655 ✔ Done loading data for nodejs/node/pull/60655 ----------------------------------- PR info ------------------------------------ Title worker: remove not implemented declarations of `Worker::CloneParentEnvVars` and `Worker::SetEnvVars` (#60655) Author Artur Gawlik <artur.gawlik@icloud.com> (@arturgawlik) Branch arturgawlik:worker-remove-not-implmented-declarations -> nodejs:main Labels c++, author ready, worker, needs-ci Commits 2 - worker: remove not implemented declarations - remove not used private `snapshot_data_` field Committers 1 - arturgawlik <artur.gawlik@icloud.com> PR-URL: https://github.com/nodejs/node/pull/60655 Reviewed-By: Anna Henningsen <anna@addaleax.net> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60655 Reviewed-By: Anna Henningsen <anna@addaleax.net> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Nov 2025 15:12:12 GMT ✔ Approvals: 1 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/60655#pullrequestreview-3444593800 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-11-14T14:47:42Z: https://ci.nodejs.org/job/node-test-pull-request/70172/ - Querying data for job/node-test-pull-request/70172/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60655 From https://github.com/nodejs/node * branch refs/pull/60655/merge -> FETCH_HEAD ✔ Fetched commits as 33586d51ae28..191fed78e640 -------------------------------------------------------------------------------- [main 17088ac2de] worker: remove not implemented declarations Author: arturgawlik <artur.gawlik@icloud.com> Date: Sun Nov 9 15:59:08 2025 +0100 1 file changed, 3 deletions(-) [main 3ad46f1b54] remove not used private `snapshot_data_` field Author: arturgawlik <artur.gawlik@icloud.com> Date: Sun Nov 9 16:30:38 2025 +0100 1 file changed, 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:2188) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- worker: remove not implemented declarationshttps://github.com/nodejs/node/actions/runs/19444329912 |
|
Landed in 0db1c6e |
PR-URL: #60655 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #60655 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #60655 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #60655 Reviewed-By: Anna Henningsen <anna@addaleax.net>
In this PR https://github.com/nodejs/node/pull/31711/files#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62L537-L554 there were removed implementations for
Worker::CloneParentEnvVarsandWorker::SetEnvVars, but declarations not. This PR removes those not implemented declarations.