sqlite: fix segfault SQLTagStore when db handle is garbage collected by louwers · Pull Request #60462 · nodejs/node

louwers · 2025-10-28T15:01:30Z

Fixes #60448 by changing from a BaseObjectWeakPtr to a BaseObjectPtr.

A SQLTagStore should keep the database alive.

nodejs-github-bot · 2025-10-28T15:01:36Z

Review requested:

@nodejs/sqlite

cjihrig

Left a couple comments, but LGTM.

test/parallel/test-sqlite-template-tag.js

src/node_sqlite.h

codecov · 2025-10-28T15:58:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (fc0952f) to head (20a0eed).
⚠️ Report is 206 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60462      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.02%     
==========================================
  Files         704      704              
  Lines      208753   208760       +7     
  Branches    40279    40280       +1     
==========================================
- Hits       184844   184821      -23     
- Misses      15919    15930      +11     
- Partials     7990     8009      +19

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`80.26% <100.00%> (+0.09%)`	⬆️
src/node_sqlite.h	`80.39% <ø> (ø)`

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

lgtm

louwers · 2025-12-29T10:53:28Z

@mcollina I need to fix the issue brought up by @addaleax.

I need to figure out how to add an internal field to SQLTagStore.

louwers · 2026-01-03T22:28:30Z

I implemented @addaleax' suggestion by adding an internal field to SQLTagStore. Admittedly Claude gave a helping hand, I didn't do that before.

The tests confirms that the segfault no longer occurs and the memory leak of my previous solution also does not appear.

src/node_sqlite.cc

louwers · 2026-01-04T12:42:53Z

Could someone trigger CI? I am not a collaborator.

mcollina

lgtm

nodejs-github-bot · 2026-01-13T20:25:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70790/

nodejs-github-bot · 2026-01-20T20:59:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70927/

louwers · 2026-01-20T21:33:15Z

Tests seem to be stuck.

nodejs-github-bot · 2026-01-28T05:47:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/60462 ✔ Done loading data for nodejs/node/pull/60462 ----------------------------------- PR info ------------------------------------ Title sqlite: fix segfault SQLTagStore when db handle is garbage collected (#60462) Author Bart Louwers <bart.louwers@gmail.com> (@louwers) Branch louwers:fix-60448 -> nodejs:main Labels c++, sqlite Commits 3 - sqlite: change approach to fix segfault SQLTagStore - sqlite: add eslint ignore for no-void - sqlite: remove redundant parameter Committers 1 - Bart Louwers <bart@emeel.net> PR-URL: https://github.com/nodejs/node/pull/60462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Oct 2025 15:01:30 GMT ✔ Approvals: 5 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60462#pullrequestreview-3389333091 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/60462#pullrequestreview-3657775960 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/60462#pullrequestreview-3624591879 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/60462#pullrequestreview-3684621830 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/60462#pullrequestreview-3684626705 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-20T20:59:49Z: https://ci.nodejs.org/job/node-test-pull-request/70927/ - Querying data for job/node-test-pull-request/70927/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60462 From https://github.com/nodejs/node * branch refs/pull/60462/merge -> FETCH_HEAD ✔ Fetched commits as 74c365846533..20a0eed2c829 -------------------------------------------------------------------------------- Auto-merging src/node_sqlite.cc Auto-merging src/node_sqlite.h Auto-merging test/parallel/test-sqlite-template-tag.js [main c05ac0c37b] sqlite: change approach to fix segfault SQLTagStore Author: Bart Louwers <bart@emeel.net> Date: Sat Jan 3 23:19:30 2026 +0100 3 files changed, 51 insertions(+), 7 deletions(-) Auto-merging test/parallel/test-sqlite-template-tag.js [main 7d9121e572] sqlite: add eslint ignore for no-void Author: Bart Louwers <bart@emeel.net> Date: Sat Jan 3 23:31:19 2026 +0100 1 file changed, 2 insertions(+), 1 deletion(-) Auto-merging src/node_sqlite.cc Auto-merging src/node_sqlite.h [main 2a32ac0336] sqlite: remove redundant parameter Author: Bart Louwers <bart@emeel.net> Date: Sun Jan 4 00:25:53 2026 +0100 2 files changed, 5 insertions(+), 11 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:2364) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- sqlite: change approach to fix segfault SQLTagStore

PR-URL: #60462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

[detached HEAD 44bed5cdfc] sqlite: change approach to fix segfault SQLTagStore
Author: Bart Louwers <bart@emeel.net>
Date: Sat Jan 3 23:19:30 2026 +0100
3 files changed, 51 insertions(+), 7 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
sqlite: add eslint ignore for no-void

PR-URL: #60462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

[detached HEAD 9b9492e455] sqlite: add eslint ignore for no-void
Author: Bart Louwers <bart@emeel.net>
Date: Sat Jan 3 23:31:19 2026 +0100
1 file changed, 2 insertions(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
sqlite: remove redundant parameter

PR-URL: #60462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

[detached HEAD 5c9047f816] sqlite: remove redundant parameter
Author: Bart Louwers <bart@emeel.net>
Date: Sun Jan 4 00:25:53 2026 +0100
2 files changed, 5 insertions(+), 11 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/21426684111

nodejs-github-bot · 2026-01-31T06:35:31Z

Landed in f6464c5

PR-URL: #60462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Oct 28, 2025

cjihrig approved these changes Oct 28, 2025

View reviewed changes

test/parallel/test-sqlite-template-tag.js Outdated Show resolved Hide resolved

test/parallel/test-sqlite-template-tag.js Outdated Show resolved Hide resolved

addaleax reviewed Oct 28, 2025

View reviewed changes

src/node_sqlite.h Outdated Show resolved Hide resolved

This comment was marked as off-topic.

Sign in to view

mcollina approved these changes Dec 29, 2025

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2025

louwers marked this pull request as draft December 29, 2025 10:53

sqlite: change approach to fix segfault SQLTagStore

419cfd4

louwers force-pushed the fix-60448 branch from b8df359 to 419cfd4 Compare January 3, 2026 22:23

louwers marked this pull request as ready for review January 3, 2026 22:25

sqlite: add eslint ignore for no-void

7c71345

addaleax approved these changes Jan 3, 2026

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

sqlite: remove redundant parameter

20a0eed

mcollina approved these changes Jan 13, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2026

gurgunday approved these changes Jan 20, 2026

View reviewed changes

himself65 approved these changes Jan 20, 2026

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 28, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 28, 2026

gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2026

nodejs-github-bot merged commit f6464c5 into nodejs:main Jan 31, 2026
86 of 89 checks passed

github-actions bot mentioned this pull request Feb 2, 2026

2026-02-03, Version 25.6.0 (Current) #61635

Merged

Uh oh!

Conversation

louwers commented Oct 28, 2025

Uh oh!

nodejs-github-bot commented Oct 28, 2025

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

louwers commented Dec 29, 2025

Uh oh!

louwers commented Jan 3, 2026

Uh oh!

Uh oh!

louwers commented Jan 4, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 13, 2026

Uh oh!

nodejs-github-bot commented Jan 20, 2026

Uh oh!

louwers commented Jan 20, 2026

Uh oh!

nodejs-github-bot commented Jan 28, 2026

PR-URL: #60462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

PR-URL: #60462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

PR-URL: #60462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

[detached HEAD 5c9047f816] sqlite: remove redundant parameter Author: Bart Louwers <bart@emeel.net> Date: Sun Jan 4 00:25:53 2026 +0100 2 files changed, 5 insertions(+), 11 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Oct 28, 2025 •

edited

Loading

PR-URL: #60462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

PR-URL: #60462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

PR-URL: #60462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

[detached HEAD 5c9047f816] sqlite: remove redundant parameter
Author: Bart Louwers <bart@emeel.net>
Date: Sun Jan 4 00:25:53 2026 +0100
2 files changed, 5 insertions(+), 11 deletions(-)
Successfully rebased and updated refs/heads/main.