deps: V8: cherry-pick 72b0e27bd936432d4998e4d1762e7a8fe6d347f5#60276
Closed
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Closed
deps: V8: cherry-pick 72b0e27bd936432d4998e4d1762e7a8fe6d347f5#60276Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
Original commit message:
[regexp] Fix modifiers for ChoiceNodes
Each alternative might modify flags when their sub-graph is emitted.
We need to restore flags to the value at the beginning of a ChoiceNode
for each alternative.
Drive-by: Move regexp-modifiers test out of harmony/
Fixed: 447583670
Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/heads/main@{#102838}
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
cjihrig
approved these changes
Oct 16, 2025
Member
Is it backportable? If not, this won't really fix, #60030 which was reported on v24.x |
Member
Author
I believe so. The unmergability stems from v8/v8@df20105, but I think the commit should still be standalone if the diffs are applied manually. |
targos
added
dont-land-on-v20.x
targos
approved these changes
Oct 16, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Contributor
|
Would be nice to have it merged 🙄 |
Member
|
Unfortunately for this PR, V8 14.3 just landed on |
Member
Author
|
Submitted against v25.x, will do the same for v24.x once I've tested the backport. |
targos
added
backport-open-v24.x
Member
|
PR for v24.x: #60732 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@72b0e27
Fixes: #60030
Doesn't land on v24.x and earlier.