doc: use markdown when branch-diff major release#60179
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Oct 11, 2025
Merged
doc: use markdown when branch-diff major release#60179nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
richardlau
reviewed
Oct 9, 2025
richardlau
approved these changes
Oct 9, 2025
marco-ippolito
approved these changes
Oct 9, 2025
RafaelGSS
added
author ready
richardlau
added
the
commit-queue-squash
cjihrig
approved these changes
Oct 10, 2025
aduh95
approved these changes
Oct 10, 2025
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
While we're at it, we could remove those extra $ that do not bring much and are annoying when copying the block
| @@ -1420,9 +1420,9 @@ The commits in the generated changelog must then be organized: | |||
| * Separate all SEMVER-MAJOR, SEMVER-MINOR, and SEMVER-PATCH commits into lists | |||
|
|
|||
| ```console | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ```console | |
| ```bash |
aduh95
reviewed
Oct 10, 2025
Comment on lines
+1423
to
+1425
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-major --group --filter-release --markdown # get all majors | ||
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-minor --group --filter-release --markdown # get all minors | ||
| $ branch-diff upstream/vN-1.x upstream/vN.x --exclude-label=semver-major,semver-minor --group --filter-release --markdown # get all patches |
Contributor
There was a problem hiding this comment.
Suggested change
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-major --group --filter-release --markdown # get all majors | |
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-minor --group --filter-release --markdown # get all minors | |
| $ branch-diff upstream/vN-1.x upstream/vN.x --exclude-label=semver-major,semver-minor --group --filter-release --markdown # get all patches | |
| branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-major --group --filter-release --markdown # get all majors | |
| branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-minor --group --filter-release --markdown # get all minors | |
| branch-diff upstream/vN-1.x upstream/vN.x --exclude-label=semver-major,semver-minor --group --filter-release --markdown # get all patches |
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in aef3fc3 |
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Oct 31, 2025
PR-URL: #60179 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 7, 2025
PR-URL: #60179 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled