test: ensure assertions are reachable in test/client-proxy#60175
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 12, 2025
Merged
test: ensure assertions are reachable in test/client-proxy#60175nodejs-github-bot merged 1 commit intonodejs:mainfrom
test/client-proxy#60175nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60175 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.02%
==========================================
Files 704 704
Lines 208087 208087
Branches 40006 40005 -1
==========================================
+ Hits 184223 184273 +50
+ Misses 15869 15825 -44
+ Partials 7995 7989 -6 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Oct 9, 2025
aduh95
force-pushed
the
must-call-mustCalls-client-proxy
branch
from
a4ba32e to
aff6d5b
Compare
aduh95
added
the
author ready
Collaborator
Collaborator
Collaborator
atlowChemi
approved these changes
Oct 12, 2025
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in da9cd74 |
9 tasks
aduh95
added a commit
that referenced
this pull request
Nov 11, 2025
PR-URL: #60175 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow up of #60125