console: allow per-stream inspectOptions option#60082
Closed
addaleax wants to merge 1 commit intonodejs:mainfrom
Closed
console: allow per-stream inspectOptions option#60082addaleax wants to merge 1 commit intonodejs:mainfrom
inspectOptions option#60082addaleax wants to merge 1 commit intonodejs:mainfrom
Conversation
addaleax
added
semver-minor
We (correctly) allow different streams to be specified for `stdout` and `stderr`, so we should also allow different inspect options for these streams.
addaleax
force-pushed
the
console-inspect-options-map
branch
from
24ddc86 to
dc89673
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60082 +/- ##
==========================================
- Coverage 88.45% 88.43% -0.03%
==========================================
Files 703 703
Lines 207797 207808 +11
Branches 40021 40022 +1
==========================================
- Hits 183807 183767 -40
- Misses 15969 16019 +50
- Partials 8021 8022 +1
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Oct 1, 2025
ljharb
reviewed
Oct 1, 2025
ljharb
approved these changes
Oct 1, 2025
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
addaleax
added a commit
that referenced
this pull request
Oct 3, 2025
We (correctly) allow different streams to be specified for `stdout` and `stderr`, so we should also allow different inspect options for these streams. PR-URL: #60082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jordan Harband <[email protected]>
Member
Author
|
Landed in 79f1999 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
We (correctly) allow different streams to be specified for `stdout` and `stderr`, so we should also allow different inspect options for these streams. PR-URL: #60082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jordan Harband <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Oct 8, 2025
Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Oct 8, 2025
Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <[email protected]>
admodius1991
reviewed
Oct 9, 2025
Comment on lines
-134
to
-135
| * `inspectOptions` {Object} Specifies options that are passed along to | ||
| [`util.inspect()`][]. |
admodius1991
reviewed
Oct 9, 2025
Comment on lines
-142
to
-145
| if (inspectOptions.colors !== undefined && | ||
| options.colorMode !== undefined) { | ||
| throw new ERR_INCOMPATIBLE_OPTION_PAIR( | ||
| 'options.inspectOptions.color', 'colorMode'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (correctly) allow different streams to be specified for
stdoutandstderr, so we should also allow different inspect options for these streams.