src: remove useless dereferencing in THROW_...#60054
Closed
addaleax wants to merge 1 commit intonodejs:mainfrom
Closed
src: remove useless dereferencing in THROW_...#60054addaleax wants to merge 1 commit intonodejs:mainfrom
THROW_...#60054addaleax wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Our `THROW_...` helpers can handle strings or string views just fine, all this does is add an extra `strlen()` call that can and should be avoided.
addaleax
force-pushed
the
no-throw-dereference
branch
from
c9da352 to
027d4d1
Compare
jasnell
approved these changes
Sep 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60054 +/- ##
==========================================
+ Coverage 88.45% 88.46% +0.01%
==========================================
Files 703 703
Lines 207546 207543 -3
Branches 40011 40007 -4
==========================================
+ Hits 183591 183612 +21
+ Misses 15949 15932 -17
+ Partials 8006 7999 -7
🚀 New features to boost your workflow:
|
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
geeksilva97
approved these changes
Sep 28, 2025
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Sep 29, 2025
addaleax
added a commit
that referenced
this pull request
Sep 30, 2025
Our `THROW_...` helpers can handle strings or string views just fine, all this does is add an extra `strlen()` call that can and should be avoided. PR-URL: #60054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
Author
|
Landed in e4e859e |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
Our `THROW_...` helpers can handle strings or string views just fine, all this does is add an extra `strlen()` call that can and should be avoided. PR-URL: #60054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
THROW_...helpers can handle strings or string views just fine, all this does is add an extrastrlen()call that can and should be avoided.