src,sqlite: replace tolocalchecked with tolocal#60028
Closed
geeksilva97 wants to merge 3 commits intonodejs:mainfrom
Closed
src,sqlite: replace tolocalchecked with tolocal#60028geeksilva97 wants to merge 3 commits intonodejs:mainfrom
geeksilva97 wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
addaleax
approved these changes
Sep 26, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60028 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01%
==========================================
Files 703 703
Lines 207546 207551 +5
Branches 40006 40001 -5
==========================================
- Hits 183631 183622 -9
- Misses 15907 15912 +5
- Partials 8008 8017 +9
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Sep 26, 2025
jasnell
approved these changes
Sep 26, 2025
Collaborator
gurgunday
approved these changes
Sep 28, 2025
louwers
reviewed
Sep 28, 2025
louwers
reviewed
Sep 28, 2025
Contributor
There was a problem hiding this comment.
Thanks, this was still one of the open issues for the session extension integration.
I think this implementation makes it possible that a changeset is being applied partially. Not a big deal, the user could just wrap it in a transaction. Just something to be aware of.
I think we should do a rollback if any exception is being thrown from either the filter callback or the conflict handler before stabilizing the SQLite API. But for now, this is an improvement.
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src,sqlite: replace tolocalchecked with tolocal ⚠ - src: implement addaleax suggestions ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/18080613898 |
louwers
approved these changes
Sep 29, 2025
cjihrig
approved these changes
Sep 29, 2025
Collaborator
Collaborator
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Sep 30, 2025
PR-URL: #60028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 4136934 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
ToLocalCheckedwithToLocalin multiple places so we prevent unexpected crashes.