test: expand tls-check-server-identity coverage

[diangogav]

• Falsy pattern via SAN: DNS: (triggers if (!pattern) return false)
• CN array with empty string: CN: ['']
• Empty label in pattern: bad..example.com (CN and SAN)
• Non-ASCII/blank label: caf\u00E9.example.com and bad label.com
• Multiple wildcards in first label: b**.a.com (CN and SAN)
• Prefix mismatch with single wildcard: ab*cd.a.com vs xbcd.a.com (CN and SAN)

[Hritikk999]

Waiting for approval;
Load approved;
Load approval in Phase T BLOCK; Block released by Developer Node;
Markdown supported in OS

[RafaelGSS]

Could you expand on why these additional checks are important? Any coverage info?

[diangogav]

Hellooo @RafaelGSS ! I saw that some validations in the check function were not covered when looking at the coverage, and that is what this PR covers.

https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Ftls.js

[RafaelGSS]

Never mind, the link you originally sent is enough. LGTM with green ci!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69367/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (d2ff9da) to head (fd96c23).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #60002   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         703      703           
  Lines      207545   207529   -16     
  Branches    40013    40010    -3     
=======================================
- Hits       183578   183572    -6     
+ Misses      15957    15940   -17     
- Partials     8010     8017    +7     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[addaleax]

Landed in 93ee08c