build: test on Python 3.14#59983
Conversation
|
Review requested:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
ba01e24 to
97f2670
Compare
97f2670 to
40575dc
Compare
40575dc to
109d743
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59983 +/- ##
==========================================
- Coverage 88.46% 88.45% -0.01%
==========================================
Files 703 703
Lines 207368 207368
Branches 39983 39980 -3
==========================================
- Hits 183438 183427 -11
+ Misses 15933 15931 -2
- Partials 7997 8010 +13 🚀 New features to boost your workflow:
|
|
Python 3.14 (the π version) was released today. |
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} | ||
| allow-prereleases: true |
There was a problem hiding this comment.
I guess we dont need this anymore?
There was a problem hiding this comment.
I usually just leave them in place so we can test Python 3.15, etc.
Commit Queue failed- Loading data for nodejs/node/pull/59983 ✔ Done loading data for nodejs/node/pull/59983 ----------------------------------- PR info ------------------------------------ Title build: test on Python 3.14 (#59983) Author Christian Clauss <[email protected]> (@cclauss) Branch cclauss:Python-3.14 -> nodejs:main Labels build, meta, notable-change, python, needs-ci, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 1 - build: test on Python 3.14 release candidate 3 Committers 1 - Christian Clauss <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59983 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59983 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 Sep 2025 08:18:28 GMT ✔ Approvals: 3 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/59983#pullrequestreview-3310896434 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59983#pullrequestreview-3322183767 ✔ - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/59983#pullrequestreview-3322391175 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-10-13T12:36:32Z: https://ci.nodejs.org/job/node-test-pull-request/69707/ - Querying data for job/node-test-pull-request/69707/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18467231844 |
|
Landed in 8bc7dfd |
Node 25 is tested with Python 3.14! Refs: nodejs/node#59983 Signed-off-by: Mike Fiedler <[email protected]>
SQUASHED UPSTREAM COMMITS: tools: make nodedownload module compatible with Python 3.14 FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14. Fixes: nodejs#58740 PR-URL: nodejs#58752 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> build: test on Python 3.14 release candidate 3 Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
SQUASHED UPSTREAM COMMITS: build: test on Python 3.14 release candidate 3 Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Backport-PR-URL: nodejs#61370 Co-authored-by: Mike McCready <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Refs: nodejs#60874
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: #59983 Backport-PR-URL: #61370 Co-authored-by: Mike McCready <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Refs: #60874
Python v3.14 -- October 7th