Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
approved these changes
Sep 20, 2025
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
Lgtm but the test could use a comment that explains the expectations a bit as most folks aren't familiar with jspi yet and won't have much context.
richardlau
added
semver-minor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59941 +/- ##
==========================================
+ Coverage 88.25% 88.44% +0.19%
==========================================
Files 703 703
Lines 207412 207402 -10
Branches 39893 39991 +98
==========================================
+ Hits 183052 183445 +393
+ Misses 16313 15930 -383
+ Partials 8047 8027 -20
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Sep 20, 2025
lpinca
approved these changes
Sep 20, 2025
Contributor
Author
|
Sure, I've added some more documentation to the test. |
Collaborator
guybedford
added a commit
that referenced
this pull request
Sep 23, 2025
PR-URL: #59941 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
Author
|
Landed in 4396cf2. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the WebAssembly JS Promise Integration Stage 4 WebAssembly proposal which is currently shipped in Chrome.
A new Wasm test is also included to verify that it works correctly.