win,tools: Add description to signature

[martincostello]

When signing files for Windows, add "Node.js" as the description.

This should cause the string highlighted in the UAC elevation prompt screenshot below to be replaced with the string specified as the description.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69395/

[martincostello]

Test failures look like flaky tests on macOS.

Can someone re-run and merge please?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69518/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69520/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69522/

[nodejs-github-bot]

Landed in 85b0e06

[bigHt800]

👀

When signing files for Windows, add "Node.js" as the description.

This should cause the string highlighted in the UAC elevation prompt screenshot below to be replaced with the string specified as the description.

[marco-ippolito]

@martincostello this requires manual backport to v20

[martincostello]

I don't know what that involves.

[marco-ippolito]

It involves cherry-pick'ing 85b0e06 on a branch targeting the v20.x-staging branch

[martincostello]

I won't have access to a computer for several days, so if it's urgent someone else will need to do that.

It sounds like a task that should be automated in-repo that the maintainers can self-manage.

[marco-ippolito]

I won't have access to a computer for several days, so if it's urgent someone else will need to do that.

It sounds like a task that should be automated in-repo that the maintainers can self-manage.

The commit needs to be adapted because the branches are divergent. If you are interested in making sure this change arrives in v20 feel free to open a backport PR

[aduh95]

To clarify, when Marco says "requires", he means "if we want this change on 20.x, it can't happen without a manual backport PR". He pinged you because as the author of the change, you're probably in the best position to do the backport, but it doesn't have to be you, like any work in Node.js someone needs to volunteer to do the work.
Looking at the change, because #58502 was never backported, I don't think this change can be backported anyway, because we don't use signtool, so no action is needed here IIUC.