typings: update 'types' binding#59692
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 24, 2025
Merged
Conversation
- Adds: - isGeneratorObject - isProxy - isSharedArrayBuffer - isSymbolObject - Removes: - isTypedArray - Fixes: - isDate - isNativeError - isRegExp - Improves: - isArgumentsObject - isExternal
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59692 +/- ##
==========================================
+ Coverage 89.86% 89.91% +0.05%
==========================================
Files 667 667
Lines 196792 196792
Branches 38632 38414 -218
==========================================
+ Hits 176842 176945 +103
+ Misses 12370 12266 -104
- Partials 7580 7581 +1
🚀 New features to boost your workflow:
|
daeyeon
approved these changes
Sep 1, 2025
daeyeon
added
the
author ready
legendecas
approved these changes
Sep 1, 2025
BridgeAR
approved these changes
Sep 14, 2025
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Sep 15, 2025
Collaborator
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e4e86ea |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
- Adds: - isGeneratorObject - isProxy - isSharedArrayBuffer - isSymbolObject - Removes: - isTypedArray - Fixes: - isDate - isNativeError - isRegExp - Improves: - isArgumentsObject - isExternal PR-URL: #59692 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 11, 2025
- Adds: - isGeneratorObject - isProxy - isSharedArrayBuffer - isSymbolObject - Removes: - isTypedArray - Fixes: - isDate - isNativeError - isRegExp - Improves: - isArgumentsObject - isExternal PR-URL: #59692 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 11, 2025
- Adds: - isGeneratorObject - isProxy - isSharedArrayBuffer - isSymbolObject - Removes: - isTypedArray - Fixes: - isDate - isNativeError - isRegExp - Improves: - isArgumentsObject - isExternal PR-URL: #59692 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IArgumentsto describe the built-inargumentsobject.objectis the non-primitive object type.Objectresolves to any value that is notnullorundefined.These definitions remain compatible with TS 3.9+, as before.
Also sorts the macro list in node_types.cc and matches the ordering in types.d.ts to the source, for ease of maintenance.