[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8#59663
Closed
Xiao-Tao wants to merge 1 commit intonodejs:v22.x-stagingfrom
Closed
[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8#59663Xiao-Tao wants to merge 1 commit intonodejs:v22.x-stagingfrom
Xiao-Tao wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
Origin commit message:
[loong64][codegen] Avoid memory access under stack pointer
According to LoongArch ABI doc chapter 8.2:
"Procedures must not assume the persistence on-stack data of which
the addresses lie below the stack pointer."
Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#101634}
Refs: v8/v8@6b1b9bc
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
marco-ippolito
approved these changes
Sep 3, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
richardlau
pushed a commit
that referenced
this pull request
Sep 19, 2025
Origin commit message:
[loong64][codegen] Avoid memory access under stack pointer
According to LoongArch ABI doc chapter 8.2:
"Procedures must not assume the persistence on-stack data of which
the addresses lie below the stack pointer."
Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#101634}
Refs: v8/v8@6b1b9bc
Backport-PR-URL: #59663
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Member
|
Landed in 2986eca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #59283 to v22.x.
CC: @marco-ippolito @aduh95