doc: remove redundant parameter comments from fs#5952
Closed
firedfox wants to merge 1 commit intonodejs:masterfrom
Closed
doc: remove redundant parameter comments from fs#5952firedfox wants to merge 1 commit intonodejs:masterfrom
firedfox wants to merge 1 commit intonodejs:masterfrom
Conversation
Some old version parameter comments are left in fs.markdown. Remove them.
Contributor
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
Contributor
|
LGTM, landed in 4039ef1. |
silverwind
pushed a commit
that referenced
this pull request
Mar 30, 2016
Some old version parameter comments are left in fs.markdown. Remove them. PR-URL: #5952 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Contributor
|
Not applicable for LTS because 060e5f0 that introduced the issue is a |
Contributor
|
@silverwind in future if PR's are not applicable can you add the Thanks for the hard work!!! |
Member
|
Quite odd. Glad this was caught. Thank you! |
Contributor
|
as far as I can tell it would seem like these changes are only applicable to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
If this change fixes a bug (or a performance problem), is a regressiontest (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
Description of change
Some old version parameter comments are left in the fs doc. Such as following
pathandcallbackat last:This change removes them.
See commit 060e5f0 and #5943 for reference.