[v22.x backport] expose setupInstance method on WASI class#59255
Open
toyobayashi wants to merge 11 commits intonodejs:v22.x-stagingfrom
Open
[v22.x backport] expose setupInstance method on WASI class#59255toyobayashi wants to merge 11 commits intonodejs:v22.x-stagingfrom
setupInstance method on WASI class#59255toyobayashi wants to merge 11 commits intonodejs:v22.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Collaborator
Contributor
Author
|
@aduh95 Sorry I have no idea why this error occurred and I can't debug under |
flakey5
approved these changes
Jul 28, 2025
aduh95
force-pushed
the
v22.x-staging
branch
2 times, most recently
from
6bb153b to
f64f5df
Compare
Contributor
|
I don't think skipping is the right approach, if this is causing a regression, we should either not backport it, or fix the regression first |
It's been a bit of a code smell that we create these objects in different conditional branches, effectively forcing ourselves to duplicate logic between those branches. This code predates `std::optional` being available to us, but now that it is, it's the idiomatic way to resolve this issue. (This commit also explicitly deletes move and copy members for these classes; these had previously been omitted for brevity, but adding them made me feel more confident that there is no hidden copy operation added through this change.) PR-URL: nodejs#59960 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: nodejs#59954 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: nodejs#59814 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This avoids explicit calls to the user-mutable `%Promise.prototype%.catch`, and by association, implicit calls to the user-mutable `%Promise.prototype%.then`. PR-URL: nodejs#59841 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
These were intended to mimic simple async functions, but exceptions thrown in the function body would be returned synchronously, not wrapped in a rejected Promise. PR-URL: nodejs#59841 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This offers _some_ resistance to `%Promise.prototype%` pollution. Refs: nodejs#59699 PR-URL: nodejs#59841 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#59851 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This patch makes the off-thread loading lazy and only done when the `tls` builtin is actually loaded by the application. Thus if the application never uses tls, it would not get hit by the extra off-thread loading overhead. paving the way to enable --use-system-ca by default. PR-URL: nodejs#59856 Reviewed-By: James M Snell <jasnell@gmail.com>
This patch makes the certificate pre-loading thread load the bundled and extra certificates from the other thread as well. PR-URL: nodejs#59856 Reviewed-By: James M Snell <jasnell@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Sorry misread the diff - @aduh95 it seems you are correct to flag this. |
PR-URL: nodejs#57214 Reviewed-By: Guy Bedford <guybedford@gmail.com>
toyobayashi
force-pushed
the
backport-wasi-finalizebindings-to-v22.x
branch
from
8508643 to
f6129a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #57214