Conversation
|
Can I ask you to include a brief description of what issue this PR is addressing or what it is changing in the PR text? :-) |
| return ReflectSet(target, prop, value); | ||
| }, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
What kind of performance impact will this have? inspect.colors is accessed in a for loop inside styleText and accessing via a Proxy (even without a get trap) will have a definite performance impact in such cases, so we should be careful here.
|
I was thinking to make sure inspect.colors is checked type in runtime (from PR #59098). But just realized this is not gonna work. And yeah it's cause performance issue. So im closing this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59107 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.01%
==========================================
Files 645 645
Lines 189153 189171 +18
Branches 37093 37099 +6
==========================================
+ Hits 170339 170342 +3
- Misses 11518 11528 +10
- Partials 7296 7301 +5
🚀 New features to boost your workflow:
|
No description provided.