doc: reformat & improve node.1 manual page#5891
Closed
Fishrock123 wants to merge 3 commits intonodejs:v4.x-stagingfrom
Closed
doc: reformat & improve node.1 manual page#5891Fishrock123 wants to merge 3 commits intonodejs:v4.x-stagingfrom
Fishrock123 wants to merge 3 commits intonodejs:v4.x-stagingfrom
Conversation
Event 9 must include the string terminator in the last descriptor. Event 23 must be published with no descriptors, in accordance with the manifest. PR-URL: nodejs#5742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
fs.readFile, fs.writeFile and fs.appendFile doc changes pulled back from master included details not relevant to v4. PR-URL: nodejs#5877 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Uses better troff formatting. Removes v8 options from the man page. Also edits `node -h` in node.cc slightly.
| focused on creating simple, easy to build network clients | ||
| and servers. | ||
| Node.js is a set of libraries for JavaScript which allows it to be used outside | ||
| of the browser. It is primarily focused on creating simple, easy to build |
Member
There was a problem hiding this comment.
Nit: easy to build -> easy-to-build
Member
|
Nit: Verb usage should be consistent. In some command descriptions, it says |
Contributor
Author
|
@Trott Please open a PR correcting these against master, I will not be fixing them in the port. |
Contributor
Author
|
@thealphanerd if lgty land at will into whatever branch |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
2d65b05 to
ebe4eb6
Compare
Contributor
|
Landed in a761235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Affected core subsystem(s)
Description of change
see #5497 (comment)
cc @thealphanerd