deps: V8: cherry-pick 0ce2edb7adfd#58773
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jul 4, 2025
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Contributor
Author
|
I think the failed tests are not related to this PR. It appears that the CI is flaky. |
Collaborator
9 tasks
Collaborator
Original commit message:
Fix invalid template specialization
Bug: chromium:40565911
Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99987}
Refs: v8/v8@0ce2edb
Fixes: nodejs#58485
targos
approved these changes
Jul 3, 2025
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
Rebased to fix a conflict. A fresh CI was needed anyway for Windows.
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
Can someone else review or @lpinca reapprove? |
targos
added
the
author ready
richardlau
approved these changes
Jul 4, 2025
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1539f3b |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
Original commit message:
Fix invalid template specialization
Bug: chromium:40565911
Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99987}
Refs: v8/v8@0ce2edb
Fixes: #58485
PR-URL: #58773
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95
added
the
backport-requested-v22.x
Contributor
|
This doesn't land cleanly on v22.x-staging, if we want it on v22.x, we'd need a manual backport PR |
Contributor
Author
v22.x does not need this so we dont need a manual backport. |
aduh95
added
dont-land-on-v22.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@0ce2edb
Fixes: #58485
This PR fixes build error on riscv64 with gcc compiler(#58485).
This PR needs to be picked into v24.x.
Note that this PR will conflict with #58746. I will rebase #58746 once this one is merged.