test_runner: prefer Atomics primordials#58716
Merged
aduh95 merged 1 commit intonodejs:mainfrom Jun 17, 2025
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
JakobJingleheimer
approved these changes
Jun 15, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58716 +/- ##
=======================================
Coverage 90.15% 90.16%
=======================================
Files 639 639
Lines 188201 188195 -6
Branches 36915 36916 +1
=======================================
+ Hits 169675 169679 +4
+ Misses 11274 11273 -1
+ Partials 7252 7243 -9
🚀 New features to boost your workflow:
|
LiviaMedeiros
approved these changes
Jun 15, 2025
pmarchini
approved these changes
Jun 15, 2025
Member
|
/cc @Renegade334 just in case. |
Member
|
Thanks all. |
ljharb
approved these changes
Jun 15, 2025
Ethan-Arrowood
approved these changes
Jun 16, 2025
PR-URL: nodejs#58716 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
force-pushed
the
test_runner-atomics-primordials
branch
from
7bba030 to
ef2e084
Compare
Contributor
Author
|
Landed in ef2e084 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
PR-URL: #58716 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This was referenced Jun 23, 2025
richardlau
pushed a commit
that referenced
this pull request
Sep 20, 2025
PR-URL: #58716 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #58577