Closed
Conversation
nodejs#5862 removed irrelevant data about fs.readFile
Contributor
|
I'm not sure if it was intentional that file descriptors are not working with |
Member
|
@ToPal ... thanks for this. Since this is for v4.x, the PR actually needs to be opened against the v4.x-staging branch instead of directly against v4.x. We land all changes into the staging branch first and only pull things into v4.x when there's a release. |
removed irrelevant data about fs.readFile
Author
|
Thanks, @mscdex! I fixed it. |
Author
|
@jasnell Thank you for information! I've created a new pull request for branch v4.x-staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #5862.
Removed irrelevant data about fs.readFile in docs for version 4.x