src: remove unused internalVerifyIntegrity internal binding#58285
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 13, 2025
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58285 +/- ##
==========================================
+ Coverage 90.18% 90.19% +0.01%
==========================================
Files 631 631
Lines 186687 186659 -28
Branches 36663 36661 -2
==========================================
+ Hits 168355 168364 +9
+ Misses 11124 11100 -24
+ Partials 7208 7195 -13
🚀 New features to boost your workflow:
|
panva
approved these changes
May 12, 2025
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
May 12, 2025
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fd0d852 |
dario-piotrowicz
deleted the
dario/remove-internalVerifyIntegrity-unused-internal-binding
branch
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58285 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
added
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is removing the
internalVerifyIntegrityinternal binding, which I believe is no longer used.I believe that the binding stopped being used in #52583 (see
lib/internal/policy/manifest.jsline 30).