tools: exclude deps/v8/tools from CodeQL scans#58132
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 5, 2025
Merged
tools: exclude deps/v8/tools from CodeQL scans#58132nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
This will remove three of the four "A parse error occurred" issues during JavaScript CodeQL scans. (The fourth occurrence is in our code base, although it might be a false positive. Someone can figure that one out sooner or later, but we certainly can bypass scanning V8 tools.)
nodejs-github-bot
added
the
meta
Member
Author
|
Test run of this change in my fork: https://github.com/Trott/io.js/actions/runs/14807712228 |
juanarbol
approved these changes
May 3, 2025
Member
Author
Confirmed that this eliminates three of the four parse errors, as expected. |
Trott
added
author ready
cjihrig
approved these changes
May 3, 2025
trivikr
approved these changes
May 3, 2025
bjohansebas
approved these changes
May 3, 2025
UlisesGascon
approved these changes
May 3, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c46b2b9 |
aduh95
pushed a commit
that referenced
this pull request
May 8, 2025
This will remove three of the four "A parse error occurred" issues during JavaScript CodeQL scans. (The fourth occurrence is in our code base, although it might be a false positive. Someone can figure that one out sooner or later, but we certainly can bypass scanning V8 tools.) PR-URL: #58132 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
This will remove three of the four "A parse error occurred" issues during JavaScript CodeQL scans. (The fourth occurrence is in our code base, although it might be a false positive. Someone can figure that one out sooner or later, but we certainly can bypass scanning V8 tools.) PR-URL: #58132 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remove three of the four "A parse error occurred" issues during JavaScript CodeQL scans. (The fourth occurrence is in our code base, although it might be a false positive. Someone can figure that one out sooner or later, but we certainly can bypass scanning V8 tools.)