src: improve parsing of boolean options by geeksilva97 · Pull Request #58039 · nodejs/node

geeksilva97 · 2025-04-26T17:58:37Z

This PR changes the way booleans are parsed from the config file. Instead of setting --flag=true|false, it adds or not the flag to the options

nodejs-github-bot · 2025-04-26T17:58:42Z

Review requested:

@nodejs/config

geeksilva97 · 2025-04-26T18:00:17Z

cc @avivkeller

geeksilva97 · 2025-04-26T18:40:44Z

This allows passing inspect flag as a boolean. Which I think is the best we can do for now in node_config_file since the env_options_map holds tne --inspect entry as a boolean.

codecov · 2025-04-26T18:47:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (68cc1c9) to head (71d8cfc).
Report is 49 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58039      +/-   ##
==========================================
- Coverage   90.26%   90.20%   -0.06%     
==========================================
  Files         630      630              
  Lines      186159   186446     +287     
  Branches    36474    36620     +146     
==========================================
+ Hits       168036   168189     +153     
- Misses      10974    11044      +70     
- Partials     7149     7213      +64

Files with missing lines	Coverage Δ
src/node_config_file.cc	`73.38% <100.00%> (+0.19%)`	⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

test/parallel/test-config-file.js

src/node_config_file.cc

marco-ippolito · 2025-04-29T13:08:27Z

LGTM with the require('node:inspector').url() suggestion

geeksilva97 · 2025-04-30T14:32:00Z

LGTM with the require('node:inspector').url() suggestion

will do

test/parallel/test-config-file.js

Co-authored-by: Marco Ippolito <[email protected]>

nodejs-github-bot · 2025-04-30T16:10:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66517/

nodejs-github-bot · 2025-04-30T18:38:53Z

Commit Queue failed

- Loading data for nodejs/node/pull/58039
✔  Done loading data for nodejs/node/pull/58039
----------------------------------- PR info ------------------------------------
Title      src: improve parsing of boolean options (#58039)
Author     Edy Silva <[email protected]> (@geeksilva97)
Branch     geeksilva97:improve-boolean-parsing -> nodejs:main
Labels     c++, author ready, commit-queue-squash, config
Commits    3
 - src: improve parsing of boolean options
 - test: update test
 - fixup: remove unneeded flag
Committers 2
 - Edy Silva <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58039
Reviewed-By: Marco Ippolito <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58039
Reviewed-By: Marco Ippolito <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 26 Apr 2025 17:58:37 GMT
   ✔  Approvals: 1
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58039#pullrequestreview-2807571351
   ✘  This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-04-30T16:10:21Z: https://ci.nodejs.org/job/node-test-pull-request/66517/
- Querying data for job/node-test-pull-request/66517/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14761825273

marco-ippolito · 2025-04-30T18:43:45Z

It needs 1 more approval to land or has to wait a few more days
@nodejs/config

nodejs-github-bot · 2025-04-30T19:08:59Z

Landed in 102d8cf

PR-URL: #58039 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Apr 26, 2025

src: improve parsing of boolean options

01cedaa

geeksilva97 force-pushed the improve-boolean-parsing branch from bf2dcc5 to 01cedaa Compare April 26, 2025 17:59

geeksilva97 requested a review from marco-ippolito April 26, 2025 17:59

marco-ippolito reviewed Apr 26, 2025

View reviewed changes

test/parallel/test-config-file.js Outdated Show resolved Hide resolved

marco-ippolito reviewed Apr 27, 2025

View reviewed changes

src/node_config_file.cc Show resolved Hide resolved

test: update test

46c2588

marco-ippolito reviewed Apr 30, 2025

View reviewed changes

test/parallel/test-config-file.js Outdated Show resolved Hide resolved

fixup: remove unneeded flag

71d8cfc

Co-authored-by: Marco Ippolito <[email protected]>

geeksilva97 requested a review from marco-ippolito April 30, 2025 15:37

marco-ippolito approved these changes Apr 30, 2025

View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 30, 2025

cjihrig approved these changes Apr 30, 2025

View reviewed changes

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 30, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2025

nodejs-github-bot merged commit 102d8cf into nodejs:main Apr 30, 2025
76 checks passed

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

src: improve parsing of boolean options

badb4f5

PR-URL: #58039 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

src: improve parsing of boolean options

130eaa2

PR-URL: #58039 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

geeksilva97 deleted the improve-boolean-parsing branch May 20, 2025 00:46

geeksilva97 mentioned this pull request Jun 7, 2025

node.config.json doesn't respect optionally-valued or aliased options #57960

Closed

aduh95 pushed a commit that referenced this pull request Jun 10, 2025

src: improve parsing of boolean options

cab2423

PR-URL: #58039 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

github-actions bot mentioned this pull request Jun 10, 2025

2025-06-24, Version 22.17.0 'Jod' (LTS) #58665

Merged

geeksilva97 mentioned this pull request Jul 18, 2025

src,test: fix config file parsing for flags defaulted to true #59110

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

src: improve parsing of boolean options#58039

src: improve parsing of boolean options#58039
nodejs-github-bot merged 3 commits intonodejs:mainfrom
geeksilva97:improve-boolean-parsing

geeksilva97 commented Apr 26, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 26, 2025

Uh oh!

geeksilva97 commented Apr 26, 2025

Uh oh!

geeksilva97 commented Apr 26, 2025

Uh oh!

codecov bot commented Apr 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

marco-ippolito commented Apr 29, 2025

Uh oh!

geeksilva97 commented Apr 30, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

marco-ippolito commented Apr 30, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

geeksilva97 commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 26, 2025

Uh oh!

geeksilva97 commented Apr 26, 2025

Uh oh!

geeksilva97 commented Apr 26, 2025

Uh oh!

codecov bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

marco-ippolito commented Apr 29, 2025

Uh oh!

geeksilva97 commented Apr 30, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

marco-ippolito commented Apr 30, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

geeksilva97 commented Apr 26, 2025 •

edited

Loading

codecov bot commented Apr 26, 2025 •

edited

Loading