test: deflake test-http2-options-max-headers-block-length#57959
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 24, 2025
Merged
Conversation
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it.
Member
Author
|
Member
Author
|
It is also easy to reproduce locally. Before After |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57959 +/- ##
=======================================
Coverage 90.26% 90.27%
=======================================
Files 630 630
Lines 186137 186142 +5
Branches 36476 36480 +4
=======================================
+ Hits 168018 168041 +23
+ Misses 10979 10978 -1
+ Partials 7140 7123 -17 🚀 New features to boost your workflow:
|
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14574096677 |
LiviaMedeiros
approved these changes
Apr 21, 2025
Collaborator
joyeecheung
approved these changes
Apr 21, 2025
Member
joyeecheung
left a comment
There was a problem hiding this comment.
It feels like a gotcha in the API to me that the client can get another error event if the goaway is not coming in fast enough when the client reads the socket (or is that a bug? cc @nodejs/http2 )..but then the docs doesn't say that it's impossible anyway.
bjohansebas
approved these changes
Apr 22, 2025
Collaborator
Collaborator
|
Landed in 555aeb3 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 10, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 11, 2025
The socket can be closed while data is still being written, causing an `ECONNRESET` error to be emitted on the client. Add a listener for it. PR-URL: #57959 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket can be closed while data is still being written, causing an
ECONNRESETerror to be emitted on the client. Add a listener for it.