src: improve error handling in cares_wrap#57937
Closed
jasnell wants to merge 2 commits intonodejs:mainfrom
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Collaborator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57937 +/- ##
==========================================
- Coverage 92.26% 90.19% -2.07%
==========================================
Files 325 630 +305
Lines 126673 186174 +59501
Branches 20783 36562 +15779
==========================================
+ Hits 116869 167923 +51054
- Misses 9576 11066 +1490
- Partials 228 7185 +6957
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Apr 20, 2025
jasnell
added a commit
that referenced
this pull request
Apr 27, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
jasnell
added a commit
that referenced
this pull request
Apr 27, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
Member
Author
|
Landed in e716081...49bb0ae |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57937 Reviewed-By: Yagiz Nizipli <[email protected]>
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling in cares_wrap by replacing
ToLocalChecked()andCheck()calls.Reduce some code duplication using macros