lib: fix default AbortController.abort() message#57735
lib: fix default AbortController.abort() message#57735nektro wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57735 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 630 630
Lines 185074 184982 -92
Branches 36221 36218 -3
==========================================
- Hits 166994 166946 -48
+ Misses 11036 10990 -46
- Partials 7044 7046 +2
🚀 New features to boost your workflow:
|
RaisinTen
left a comment
There was a problem hiding this comment.
LGTM but you need to update the expected error messages in the tests
|
Where does the spec dictate that the description must be the error message? For example I'm pretty sure if we implemented URLMismatchError its message wouldn't be "Deprecated.". |
|
taking another look, https://webidl.spec.whatwg.org/#js-creating-throwing-exceptions for DOMException says message is implementation defined. initially opened this because while investigating other code we noticed Safari, Firefox, Bun use the default description from the spec |
did not previously match spec https://dom.spec.whatwg.org/#dom-abortsignal-abort https://webidl.spec.whatwg.org/#aborterror Co-authored-by: pfg <pfg@pfg.pw>
|
See https://nodejs.org/api/errors.html#errorcode, error message can be changed in any versions of Node.js. I don't think this is necessarily a semver major change. |
|
Mostly being careful because this will break things, mostly tests https://github.com/search?q=%22This+operation+was+aborted%22&type=code |
PR-URL: nodejs#57783 Refs: nodejs#57735 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
bump |
did not previously match spec
https://dom.spec.whatwg.org/#dom-abortsignal-abort
https://webidl.spec.whatwg.org/#aborterror