lib: deprecate _tls_common and _tls_wrap by dario-piotrowicz · Pull Request #57643 · nodejs/node

dario-piotrowicz · 2025-03-27T00:44:59Z

This PR is for runtime deprecation of the _tls_common and _tls_wrap modules

My hope is to manage to gradually deprecate the various _ modules that are not documented
and that should not be part of node.js' public API (for more context see: #57540 (comment))

Interestingly as you can see:

common and wrap expose respectively:

SecureContext
createSecureContext
translatePeerCertificate
and
TLSSocket
Server
createServer
connect

All of these, seem to already being re-exported by node:tls:

node/lib/tls.js

Lines 389 to 394 in 186bbf7

    
           exports.createSecureContext = _tls_common.createSecureContext; 
        
           exports.SecureContext = _tls_common.SecureContext; 
        
           exports.TLSSocket = _tls_wrap.TLSSocket; 
        
           exports.Server = _tls_wrap.Server; 
        
           exports.createServer = _tls_wrap.createServer; 
        
           exports.connect = _tls_wrap.connect;

the only exception being translatePeerCertificate (which I am not really very familiar with, but by the looks of it
seems like a rather simple function that can be re-implemented externally)

So I don't think that deprecating these modules should have huge impacts to users and that importing from
node:tls instead is a viable alternative

@BridgeAR 🙂👍

nodejs-github-bot · 2025-03-27T00:45:04Z

Review requested:

@nodejs/crypto
@nodejs/net

dario-piotrowicz · 2025-03-27T00:46:21Z

@BridgeAR I know you said that the runtime deprecation wasn't completely necessary but I really wanted to give it a shot (and I really like how it turned out 😄) I hope you don't mind 🙂

codecov · 2025-03-27T03:43:41Z

Codecov Report

❌ Patch coverage is 94.68846% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.18%. Comparing base (535c2f7) to head (f96445c).
⚠️ Report is 1545 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/tls/wrap.js	94.38%	98 Missing and 2 partials ⚠️
lib/internal/tls/common.js	97.43%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57643      +/-   ##
==========================================
+ Coverage   90.12%   90.18%   +0.06%     
==========================================
  Files         629      631       +2     
  Lines      186638   186662      +24     
  Branches    36618    36656      +38     
==========================================
+ Hits       168202   168344     +142     
+ Misses      11222    11122     -100     
+ Partials     7214     7196      -18

Files with missing lines	Coverage Δ
lib/_tls_common.js	`100.00% <100.00%> (+2.56%)`	⬆️
lib/_tls_wrap.js	`100.00% <100.00%> (+5.61%)`	⬆️
lib/internal/crypto/x509.js	`91.75% <100.00%> (ø)`
lib/tls.js	`95.93% <100.00%> (ø)`
src/node_builtins.cc	`79.17% <ø> (ø)`
lib/internal/tls/common.js	`97.43% <97.43%> (ø)`
lib/internal/tls/wrap.js	`94.38% <94.38%> (ø)`

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

lgtm

mcollina

lgtm

nodejs-github-bot · 2025-04-07T08:12:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66100/

nodejs-github-bot · 2025-04-12T18:07:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66217/

jasnell · 2025-04-12T18:09:56Z

doc/api/deprecations.md

+Type: Runtime
+
+The `node:_tls_common` and `node:_tls_wrap` modules are deprecated as they should be considered
+an internal nodejs implementation rather than a public facing API, use `node:tls` instead.


Just noting... it's an unfortunate truth that while these are deprecated we likely will never be able to actually remove them. See require('sys') ....

oh I see.. that's pretty disappointing 🥲 (although I understand the security implications...)

I like your suggestion of throwing an error though, it'd be pretty nice if we could do that at some point 🙂

mh... or maybe the _ modules could be removed at some point since npm doesn't support such modules anyways? 🤔

#26292 (comment)
https://github.com/npm/validate-npm-package-name?tab=readme-ov-file#naming-rules

🤔

npm may not but an attacker could still locally inject a module which would still be problematic.

oh I see what you mean... like with a postinstall script or something that drops an _ module in the node_modules right? 🤔

oh too bad then 😓 (but I am still hoping for the throwing idea! 😀)

nodejs-github-bot · 2025-05-05T09:53:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66606/

nodejs-github-bot · 2025-05-06T10:38:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66643/

nodejs-github-bot · 2025-05-10T23:10:44Z

Landed in a822a1c

assert: * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532 * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006 assert,util: * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448 * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627 async_hooks: * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220 build: * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064 * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617 child_process: * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527 crypto: * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008 * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706 * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620 deps: * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064 * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064 * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064 * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064 * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064 * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064 * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064 * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064 dgram: * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474 dns: * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619 fs: * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536 * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616 * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672 * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 http: * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060 lib: * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920 * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337 * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643 module: * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473 node-api: * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280 perf_hooks: * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531 process: * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707 repl: * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495 src: * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705 * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471 * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469 * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470 * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064 src,permission: * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517 tls: * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064 url: * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617 util,console: * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710 worker: * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528 PR-URL: #59896

assert: * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532 * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006 assert,util: * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448 * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627 async_hooks: * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220 build: * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064 * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617 child_process: * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527 crypto: * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008 * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706 * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620 deps: * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064 * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064 * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064 * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064 * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064 * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064 * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064 * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064 dgram: * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474 dns: * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619 fs: * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536 * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616 * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672 * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 http: * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060 lib: * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920 * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337 * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643 module: * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473 node-api: * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280 perf_hooks: * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531 process: * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707 repl: * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495 src: * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705 * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471 * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469 * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470 * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064 src,permission: * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517 tls: * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064 url: * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617 util,console: * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710 worker: * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528 PR-URL: #59896 Signed-off-by: RafaelGSS <[email protected]>

assert: * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532 * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006 assert,util: * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448 * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627 async_hooks: * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #59805 * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064 * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617 child_process: * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527 crypto: * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008 * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706 * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620 deps: * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #59805 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 14.1.146.11 (Michaël Zasso) #59805 * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064 * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064 * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064 * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064 * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064 * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064 * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064 * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064 dgram: * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474 dns: * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619 doc,src,test: * (SEMVER-MAJOR) replace use of deprecated `GetIsolate` (Michaël Zasso) #59805 fs: * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536 * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616 * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672 * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 http: * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060 lib: * (SEMVER-MAJOR) use validators for argument validation (Nam Yooseong) #59416 * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920 * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337 * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643 module: * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473 node-api: * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280 perf_hooks: * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531 process: * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707 repl: * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495 src: * (SEMVER-MAJOR) update crypto.getCipherInfo() to use DictionaryTemplate (James M Snell) #60036 * (SEMVER-MAJOR) fix calls to v8::Object::wrap (Andreas Haas) #59805 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 141 (Michaël Zasso) #59805 * (SEMVER-MAJOR) improve performance of dotenv ToObject (James M Snell) #60038 * (SEMVER-MAJOR) use std::string_view from node_report (iknoom) #60006 * (SEMVER-MAJOR) unflag --experimental-webstorage by default (Daniel M Brasil) #57666 * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705 * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471 * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469 * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470 * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064 src,permission: * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517 test: * (SEMVER-MAJOR) update cppgc-object addon config (StefanStojanovic) #59805 * (SEMVER-MAJOR) spin longer for sequential/test-worker-prof (Michaël Zasso) #59805 * (SEMVER-MAJOR) remove `--always-turbofan` flag (Michaël Zasso) #59805 * (SEMVER-MAJOR) update snapshot for V8 14.1 (Michaël Zasso) #59805 test,win: * (SEMVER-MAJOR) split addon tests (StefanStojanovic) #59805 tls: * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533 tools: * (SEMVER-MAJOR) update V8 gypfiles for 14.0 (Michaël Zasso) #59805 * (SEMVER-MAJOR) update V8 gypfiles for 13.9 (Michaël Zasso) #59805 * (SEMVER-MAJOR) update V8 gypfiles for 13.8 (Michaël Zasso) #59805 * (SEMVER-MAJOR) enable leaptiering for aix/ibmi (Abdirahim Musse) #59805 * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064 url: * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617 util,console: * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710 worker: * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528 PR-URL: #59896 Signed-off-by: RafaelGSS <[email protected]>

targos · 2025-11-18T13:04:04Z

It's a bit unfortunate that a big refactoring happened in the same PR as a deprecation. I think the non-breaking changes should be backported at least to v24.x.

targos · 2025-12-13T14:56:37Z

Backport PR: #61044

This is the same as the original change, minus the `process.emitWarning` calls and unit tests that expect the deprecation warnings. Refs: nodejs#57643

This is the same as the original change, minus the `process.emitWarning` calls and unit tests that expect the deprecation warnings, plus re-application of the fixes for CVE-2025-59465 and CVE-2026-21637. Refs: nodejs#57643

This is the same as the original change, minus the `process.emitWarning` calls and unit tests that expect the deprecation warnings, plus re-application of the fixes for CVE-2025-59465 and CVE-2026-21637. Original commit message: lib: deprecate _tls_common and _tls_wrap runtime deprecate the _tls_common and _tls_wrap modules, users should use nust node:tls insteal and internally internal/tls/commond and internal/tls/wrap should be used instead PR-URL: nodejs#57643 Backport-PR-URL: nodejs#61044 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

This prevents the server from crashing due to an unhandled rejection when a TLSSocket connection is abruptly destroyed during initialization and the user has not attached an error handler to the socket. e.g: ```js const server = http2.createSecureServer({ ... }) server.on('secureConnection', socket => { socket.on('error', err => { console.log(err) }) }) ``` PR-URL: nodejs-private/node-private#750 Backport-PR-URL: nodejs#61044 Fixes: nodejs#44751 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=3262404 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> CVE-ID: CVE-2025-59465 Refs: nodejs#57643

Wrap pskCallback and ALPNCallback invocations in try-catch blocks to route exceptions through owner.destroy() instead of letting them become uncaught exceptions. This prevents remote attackers from crashing TLS servers or causing resource exhaustion. Fixes: https://hackerone.com/reports/3473882 PR-URL: nodejs-private/node-private#782 Backport-PR-URL: nodejs#61044 CVE-ID: CVE-2026-21637 Refs: nodejs#57643

This is the same as the original change, minus the `process.emitWarning` calls and unit tests that expect the deprecation warnings, plus re-application of the fixes for CVE-2025-59465 and CVE-2026-21637. Original commit message: lib: deprecate _tls_common and _tls_wrap runtime deprecate the _tls_common and _tls_wrap modules, users should use nust node:tls insteal and internally internal/tls/commond and internal/tls/wrap should be used instead PR-URL: nodejs#57643 Backport-PR-URL: nodejs#61044 Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

This prevents the server from crashing due to an unhandled rejection when a TLSSocket connection is abruptly destroyed during initialization and the user has not attached an error handler to the socket. e.g: ```js const server = http2.createSecureServer({ ... }) server.on('secureConnection', socket => { socket.on('error', err => { console.log(err) }) }) ``` PR-URL: nodejs-private/node-private#750 Backport-PR-URL: nodejs#61044 Fixes: nodejs#44751 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=3262404 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> CVE-ID: CVE-2025-59465 Refs: nodejs#57643

Wrap pskCallback and ALPNCallback invocations in try-catch blocks to route exceptions through owner.destroy() instead of letting them become uncaught exceptions. This prevents remote attackers from crashing TLS servers or causing resource exhaustion. Fixes: https://hackerone.com/reports/3473882 PR-URL: nodejs-private/node-private#782 Backport-PR-URL: nodejs#61044 CVE-ID: CVE-2026-21637 Refs: nodejs#57643

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 27, 2025

dario-piotrowicz force-pushed the dario/deprecate_tls branch 2 times, most recently from 6d4746b to 50c51bd Compare March 27, 2025 00:52

mcollina approved these changes Mar 27, 2025

View reviewed changes

lpinca added the needs-citgm PRs that need a CITGM CI run. label Mar 27, 2025

jasnell approved these changes Mar 27, 2025

View reviewed changes

marco-ippolito approved these changes Mar 28, 2025

View reviewed changes

dario-piotrowicz force-pushed the dario/deprecate_tls branch from 9d8afa9 to 0643430 Compare April 6, 2025 18:23

mcollina approved these changes Apr 7, 2025

View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. semver-major PRs that contain breaking changes and should be released in the next major version. labels Apr 7, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025

dario-piotrowicz force-pushed the dario/deprecate_tls branch 2 times, most recently from f09a338 to 15a47d9 Compare April 12, 2025 17:18

jasnell reviewed Apr 12, 2025

View reviewed changes

jasnell approved these changes Apr 12, 2025

View reviewed changes

anonrig approved these changes Apr 12, 2025

View reviewed changes

dario-piotrowicz added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2025

dario-piotrowicz force-pushed the dario/deprecate_tls branch from 15a47d9 to 2ef23ad Compare May 6, 2025 17:10

dario-piotrowicz added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025

dario-piotrowicz deleted the dario/deprecate_tls branch May 10, 2025 23:12

dario-piotrowicz mentioned this pull request May 14, 2025

lib: deprecate _stream_* modules #58337

Merged

juanarbol mentioned this pull request May 30, 2025

Getting TypeError: info.replace is not a function when using https.request #58509

Closed

This was referenced May 31, 2025

http2: deprecate priority #58313

Merged

[v24.x] Backport doc deprecations #58542

Closed

RafaelGSS mentioned this pull request Sep 15, 2025

2025-10-15, Version 25.0.0 (Current) #59896

Merged

9 tasks

targos mentioned this pull request Nov 18, 2025

fix: avoid external memory leak on invalid TLS protocol versions #60390

Merged

targos added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label Nov 18, 2025

targos added backport-open-v24.x Indicate that the PR has an open backport and removed backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. labels Dec 13, 2025

targos mentioned this pull request Dec 13, 2025

[v24.x] lib: backport _tls_common and _tls_wrap refactors #61044

Merged

targos pushed a commit to targos/node that referenced this pull request Dec 13, 2025

lib: backport _tls_common and _tls_wrap refactors

b885b3a

This is the same as the original change, minus the `process.emitWarning` calls and unit tests that expect the deprecation warnings. Refs: nodejs#57643

	exports.createSecureContext = _tls_common.createSecureContext;
	exports.SecureContext = _tls_common.SecureContext;
	exports.TLSSocket = _tls_wrap.TLSSocket;
	exports.Server = _tls_wrap.Server;
	exports.createServer = _tls_wrap.createServer;
	exports.connect = _tls_wrap.connect;

Uh oh!

Conversation

dario-piotrowicz commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 27, 2025

Uh oh!

dario-piotrowicz commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 7, 2025

Uh oh!

nodejs-github-bot commented Apr 12, 2025

Uh oh!

jasnell Apr 12, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Apr 12, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell Apr 12, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Apr 12, 2025

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 6, 2025

Uh oh!

nodejs-github-bot commented May 10, 2025

Uh oh!

targos commented Nov 18, 2025

Uh oh!

targos commented Dec 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dario-piotrowicz commented Mar 27, 2025 •

edited

Loading

dario-piotrowicz commented Mar 27, 2025 •

edited

Loading

codecov bot commented Mar 27, 2025 •

edited

Loading

dario-piotrowicz Apr 12, 2025 •

edited

Loading