sqlite,src: refactor sqlite value conversion by geeksilva97 · Pull Request #57571 · nodejs/node

geeksilva97 · 2025-03-21T01:51:17Z

This PR is a minor refactor on converting SQLite values to JS. It makes the work for #56600 easier and reduces duplication.

nodejs-github-bot · 2025-03-21T01:51:22Z

Review requested:

@nodejs/sqlite

codecov · 2025-03-21T02:59:52Z

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (1de917b) to head (94276bc).
Report is 74 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57571      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         629      630       +1     
  Lines      184903   185009     +106     
  Branches    36223    36221       -2     
==========================================
+ Hits       166853   166944      +91     
- Misses      11010    11038      +28     
+ Partials     7040     7027      -13

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`78.20% <87.50%> (-0.29%)`	⬇️

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-03-21T03:37:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65862/

Renegade334 · 2025-03-21T17:42:43Z

Is this "returning function body macro" paradigm used elsewhere? Appreciate the rationale, but it seems like it lends potential for future mishaps?

geeksilva97 · 2025-03-21T23:56:12Z

but it seems like it lends potential for future mishaps?

For this, specifically, I don't think so. This type conversion is unlikely to change. We need to find a way to isolate this anyways since it's being required more and more.

src/node_sqlite.cc

cjihrig

LGTM with one minor comment.

src/node_sqlite.cc

github-actions · 2025-04-01T13:07:39Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - sqlite,src: refactor sqlite value conversion
   ⚠  - fixup: apply review suggestions
   ⚠  - sqlite,src: improve conversion macro
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/14196415493

nodejs-github-bot · 2025-04-02T07:37:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65962/

nodejs-github-bot · 2025-04-03T14:24:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66000/

nodejs-github-bot · 2025-04-03T15:18:08Z

Landed in 8360ce2

PR-URL: nodejs#57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

sqlite,src: refactor sqlite value conversion

4299a25

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 21, 2025

geeksilva97 requested review from RafaelGSS, anonrig, cjihrig and jasnell March 21, 2025 01:53

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2025

jasnell approved these changes Mar 21, 2025

View reviewed changes

geeksilva97 mentioned this pull request Mar 22, 2025

sqlite: add aggregate function #56600

Merged

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2025

cjihrig reviewed Mar 22, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

fixup: apply review suggestions

2611aa7

geeksilva97 force-pushed the sqlite-refactor-conversion-type branch from 6cf644e to 2611aa7 Compare March 24, 2025 20:44

geeksilva97 requested review from cjihrig and jasnell March 25, 2025 18:05

jasnell approved these changes Mar 25, 2025

View reviewed changes

geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 25, 2025

cjihrig approved these changes Mar 26, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

sqlite,src: improve conversion macro

94276bc

geeksilva97 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 26, 2025

github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 1, 2025

aduh95 approved these changes Apr 2, 2025

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2025

cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Apr 3, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2025

nodejs-github-bot merged commit 8360ce2 into nodejs:main Apr 3, 2025
71 checks passed

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

sqlite,src: refactor sqlite value conversion

c123d5e

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

sqlite,src: refactor sqlite value conversion

da281d7

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite,src: refactor sqlite value conversion

f894381

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite,src: refactor sqlite value conversion

eae8119

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

sqlite,src: refactor sqlite value conversion

334441d

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 16, 2025

sqlite,src: refactor sqlite value conversion

51f0fa9

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite,src: refactor sqlite value conversion

e4e83a2

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite,src: refactor sqlite value conversion

e115abd

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite,src: refactor sqlite value conversion

11b0f0d

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request May 18, 2025

sqlite,src: refactor sqlite value conversion

00fbe64

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

sqlite,src: refactor sqlite value conversion

120050d

PR-URL: #57571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

Uh oh!

Conversation

geeksilva97 commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 21, 2025

Uh oh!

codecov bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Mar 21, 2025

Uh oh!

Renegade334 commented Mar 21, 2025

Uh oh!

geeksilva97 commented Mar 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

nodejs-github-bot commented Apr 2, 2025

Uh oh!

nodejs-github-bot commented Apr 3, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

geeksilva97 commented Mar 21, 2025 •

edited

Loading

codecov bot commented Mar 21, 2025 •

edited

Loading