Revert "src: do not expose simdjson.h in node_config_file.h"#57197
Closed
jasnell wants to merge 1 commit intonodejs:mainfrom
Closed
Revert "src: do not expose simdjson.h in node_config_file.h"#57197jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell wants to merge 1 commit intonodejs:mainfrom
Conversation
This reverts commit 8a9c3c2. This is breaking builds locally and in CI
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
nodejs-github-bot
added
c++
Collaborator
juanarbol
approved these changes
Feb 24, 2025
Member
|
I wish I was tagged to that PR, that header is indeed needed |
marco-ippolito
approved these changes
Feb 24, 2025
Member
Author
|
Interestingly that PR CI passed so I presume another PR landed in parallel? |
Member
|
Yes this one #57170 |
jasnell
added
the
author ready
richardlau
approved these changes
Feb 24, 2025
lpinca
approved these changes
Feb 24, 2025
daeyeon
approved these changes
Feb 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57197 +/- ##
==========================================
- Coverage 92.13% 90.31% -1.82%
==========================================
Files 325 630 +305
Lines 126025 184513 +58488
Branches 20654 36074 +15420
==========================================
+ Hits 116114 166646 +50532
- Misses 9687 10959 +1272
- Partials 224 6908 +6684 |
Member
Author
|
Just waiting on the excruciatingly slow windows CI jobs.... |
jasnell
added a commit
that referenced
this pull request
Feb 24, 2025
This reverts commit 8a9c3c2. This is breaking builds locally and in CI PR-URL: #57197 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
Member
Author
|
Landed in 8f4d306 |
targos
added
dont-land-on-v18.x
dont-land-on-v20.x
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
This reverts commit 8a9c3c2. This is breaking builds locally and in CI PR-URL: #57197 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
This reverts commit 8a9c3c2. This is breaking builds locally and in CI PR-URL: #57197 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
This reverts commit 8a9c3c2. This is breaking builds locally and in CI PR-URL: #57197 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
This reverts commit 8a9c3c2. This is breaking builds locally and in CI PR-URL: #57197 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a9c3c2.
This is breaking builds locally and in CI