Conversation
|
Review requested:
|
jakecastelli
left a comment
There was a problem hiding this comment.
looks good to me, except the module introduced _in version may need some confirmations
Commit Queue failed- Loading data for nodejs/node/pull/57109 ✔ Done loading data for nodejs/node/pull/57109 ----------------------------------- PR info ------------------------------------ Title doc,test: fix docs/api copy (#57109) Author 1ilsang <[email protected]> (@1ilsang) Branch 1ilsang:test/md-lint -> nodejs:main Labels tools, author ready Commits 2 - doc,test: fix docs/api copy - doc: fix introduced version Committers 1 - 1ilsang <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 17 Feb 2025 17:11:43 GMT ✔ Approvals: 3 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/57109#pullrequestreview-2625579028 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57109#pullrequestreview-2625750437 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57109#pullrequestreview-2628003039 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 57109 From https://github.com/nodejs/node * branch refs/pull/57109/merge -> FETCH_HEAD ✔ Fetched commits as f6ce48636b08..721e37db3758 -------------------------------------------------------------------------------- [main 6c319eff14] doc,test: fix docs/api copy Author: 1ilsang <[email protected]> Date: Tue Feb 18 01:59:41 2025 +0900 2 files changed, 10 insertions(+) [main d7497a1d90] doc: fix introduced version Author: 1ilsang <[email protected]> Date: Tue Feb 18 18:27:35 2025 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc,test: fix docs/api copyhttps://github.com/nodejs/node/actions/runs/13427134365 |
|
A miner suggestion for the commit messages: first commit - tools: consolidate |
721e37d to
dff2f62
Compare
|
Landed in 15fec13...867a754 |
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57109 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The Copy button doesn't work on page docs/api/typescript.
altDocsfunction is throwing an null properties error becauseintroduced_inis missing.Probably all API documentation should have
<!--introduced_in=vVERSION-->, So Added a test inlint-md.mjsas well.