[v20.x backport] deps: V8: backport 9ab40592f697#56782
Closed
kxxt wants to merge 1 commit intonodejs:v20.x-stagingfrom
Closed
[v20.x backport] deps: V8: backport 9ab40592f697#56782kxxt wants to merge 1 commit intonodejs:v20.x-stagingfrom
kxxt wants to merge 1 commit intonodejs:v20.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
aduh95
changed the title
Contributor
|
We'd need to wait for #56781 to land, and we should amend the commit message to use the metadata of the other PR |
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Jan 27, 2025
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log See more details in riscv-forks/electron#7 - Cherry-pick icache flush fix, upstreamed: - nodejs/node#56781 - nodejs/node#56782 - Should still need nocheck
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Jan 27, 2025
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log See more details in riscv-forks/electron#7 - Cherry-pick icache flush fix, upstreamed: - nodejs/node#56781 - nodejs/node#56782 - Should still need nocheck
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Jan 28, 2025
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log See more details in riscv-forks/electron#7 - Cherry-pick icache flush fix, upstreamed: - nodejs/node#56781 - nodejs/node#56782 - Should still need nocheck
targos
approved these changes
Jan 28, 2025
marco-ippolito
added
request-ci
Collaborator
Collaborator
Collaborator
Member
|
can you rebase please, the issue on smartos should have been fixed. |
Original commit message:
[riscv] Flush icache in both local and remote harts
Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.
Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97673}
Refs: v8/v8@9ab4059
Co-authored-by: kxxt <[email protected]>
Contributor
Author
Rebased. Thanks for the ping. BTW should I do anything manually targeting v22.x. #56781 should apply to v22.x (except the v8_embedder_string part). Are there any automatic way to pick #56781 into v22.x or should I open another PR like this one? |
Member
|
If lands cleanly it will be picked up automatically |
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
richardlau
approved these changes
Feb 11, 2025
marco-ippolito
approved these changes
Feb 11, 2025
Member
|
Landed in 5c9a397 |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 11, 2025
Original commit message:
[riscv] Flush icache in both local and remote harts
Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.
Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97673}
Refs: v8/v8@9ab4059
PR-URL: #56781
Backport-PR-URL: #56782
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 11, 2025
Original commit message:
[riscv] Flush icache in both local and remote harts
Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.
Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97673}
Refs: v8/v8@9ab4059
PR-URL: #56781
Backport-PR-URL: #56782
Co-authored-by: kxxt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport for v20.x of #56781
Original commit message:
Refs: v8/v8@9ab4059