Fix sqlite custom function callback errors reporting

[Charlesnorris509]

Fixes #56772

Add error reporting for custom function callback errors to the sqlite API.

• src/node_sqlite.cc

  • Call sqlite3_result_error() in UserDefinedFunction::xFunc when the JS callback throws an error.
  • Update the retval check to handle the error condition and call sqlite3_result_error().

• test/parallel/test-sqlite-custom-functions.js

  • Add a new test to verify that custom function callback errors are reported to the sqlite API.
  • Write tests to ensure that error conditions in the JS callback result in sqlite3_result_error() being called.

---

For more details, open the Copilot Workspace session.

[cjihrig]

Thanks for opening this PR. I think the correct fix requires more work though:

• There are three early returns that need to be addressed. This PR currently only addresses one of them.
• The bigger change is that we need to create state indicating that there is both a pending JavaScript exception and a SQLite error.
• Then, before creating the SQLite error object, we need to check if there is a JavaScript exception pending. If there is, we should not create the SQLite exception. I believe in its current state, this PR will surface the SQLite error and swallow the JavaScript exception.

[cjihrig]

For reference, I think the fix should look more like this - cjihrig@f113c39. Note, I already had this patch mostly written when I saw your PR.

[Charlesnorris509]

Thanks for letting me know that this issue has been previously resolved

[cjihrig]

It is not resolved yet. You are free to take it over if you want.