test: mark test-tls-min-max-version as flaky#56747
test: mark test-tls-min-max-version as flaky#56747JonasBa wants to merge 1 commit intonodejs:mainfrom
Conversation
|
cc @nodejs/platform-smartos |
|
The failure is a timeout so it might be #54918 again. |
|
mcollina
left a comment
There was a problem hiding this comment.
lgtm
I think this is our deadlock problem :(.
|
Is the test failing consistently or is it one off (timeout only)? In the latter case I would not mark it flaky or we will slowing mark every test flaky until a fix for #54918 is found. |
|
I could not find any previous failure of this test on https://github.com/nodejs/reliability so I think this is premature, but I don't want to start another fight :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56747 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 662 662
Lines 191968 191968
Branches 36955 36948 -7
=======================================
+ Hits 171269 171271 +2
- Misses 13535 13542 +7
+ Partials 7164 7155 -9 🚀 New features to boost your workflow:
|
mcollina
left a comment
There was a problem hiding this comment.
blocking for now. Happy to revise if this show up further.
Ref: #56746