[v20.x] test: skip test-buffer-tostring-range on smartos by marco-ippolito · Pull Request #56727 · nodejs/node

marco-ippolito · 2025-01-23T12:39:27Z

Unblocks v20 release #56699

Refs: #56726

@nodejs/platform-smartos

@nodejs/releasers

lpinca · 2025-01-23T13:41:21Z

Please remove Fixes: from the issue description, otherwise the tracking issue will be closed when this lands.

nodejs-github-bot · 2025-01-23T13:44:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64641/

codecov · 2025-01-23T14:07:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (d978610) to head (2588b7d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56727   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         662      662           
  Lines      191945   191945           
  Branches    36948    36945    -3     
=======================================
+ Hits       171238   171246    +8     
+ Misses      13549    13541    -8     
  Partials     7158     7158

see 23 files with indirect coverage changes

aduh95

Should this land on other release lines than 20.x? Looking at daily, it's failing only on 20.x

joyeecheung

I think on v20.x it's not flaky, it's just 100% failure...so if you plan to backport it to v20.x it might be better to just use SKIP there.

joyeecheung · 2025-01-23T14:38:37Z

Actually, no, this is not flaky on the main branch, it's only 100% failure on v20.x. See https://github.com/nodejs/reliability/blob/main/reports/2025-01-23.md - both PRs referenced are targetting v20.x

marco-ippolito · 2025-01-23T14:42:40Z

I'm move this to v20.x only

test/parallel/parallel.status

nodejs-github-bot · 2025-01-23T15:35:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64651/

nodejs-github-bot · 2025-01-25T06:38:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64737/

marco-ippolito · 2025-01-25T08:06:15Z

The branch (v20.x-staging) seems to fail consistently on windows for permission model @RafaelGSS
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32273/RUN_SUBSET=1,nodes=win11-arm64-COMPILED_BY-vs2019-arm64/console

07:42:36 not ok 598 parallel/test-permission-fs-write
07:42:36   ---
07:42:36   duration_ms: 464.99100
07:42:36   severity: fail
07:42:36   exitcode: 1
07:42:36   stack: |-
07:42:36     node:assert:90
07:42:36       throw new AssertionError(obj);
07:42:36       ^
07:42:36     
07:42:36     AssertionError [ERR_ASSERTION]: node:assert:377
07:42:36     
07:42:36           throw err;
07:42:36     
07:42:36           ^
07:42:36     
07:42:36     
07:42:36     
07:42:36     AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
07:42:36     
07:42:36     + actual - expected
07:42:36     
07:42:36     
07:42:36     
07:42:36       Comparison {
07:42:36     
07:42:36         code: 'ERR_ACCESS_DENIED',
07:42:36     
07:42:36         permission: 'FileSystemWrite',
07:42:36     
07:42:36     +   resource: 'd:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36     -   resource: '\\\\?\\d:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36       }
07:42:36     
07:42:36         at d:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:727:12
07:42:36     
07:42:36         at d:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:474:15
07:42:36     
07:42:36         at node:fs:2327:7
07:42:36     
07:42:36         at FSReqCallback.oncomplete (node:fs:188:23)
07:42:36     
07:42:36         at Object.open (node:fs:558:11)
07:42:36     
07:42:36         at Object.writeFile (node:fs:2325:6)
07:42:36     
07:42:36         at Object.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\permission\fs-write.js:38:6)
07:42:36     
07:42:36         at Module._compile (node:internal/modules/cjs/loader:1469:14)
07:42:36     
07:42:36         at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
07:42:36     
07:42:36         at Module.load (node:internal/modules/cjs/loader:1288:32) {
07:42:36     
07:42:36       generatedMessage: true,
07:42:36     
07:42:36       code: 'ERR_ASSERTION',
07:42:36     
07:42:36       actual: Error: Access to this API has been restricted
07:42:36     
07:42:36           at Object.open (node:fs:558:11)
07:42:36     
07:42:36           at Object.writeFile (node:fs:2325:6)
07:42:36     
07:42:36           at Object.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\permission\fs-write.js:38:6)
07:42:36     
07:42:36           at Module._compile (node:internal/modules/cjs/loader:1469:14)
07:42:36     
07:42:36           at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
07:42:36     
07:42:36           at Module.load (node:internal/modules/cjs/loader:1288:32)
07:42:36     
07:42:36           at Module._load (node:internal/modules/cjs/loader:1104:12)
07:42:36     
07:42:36           at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:12)
07:42:36     
07:42:36           at node:internal/main/run_main_module:28:49 {
07:42:36     
07:42:36         code: 'ERR_ACCESS_DENIED',
07:42:36     
07:42:36         permission: 'FileSystemWrite',
07:42:36     
07:42:36         resource: 'd:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36       },
07:42:36     
07:42:36       expected: {
07:42:36     
07:42:36         code: 'ERR_ACCESS_DENIED',
07:42:36     
07:42:36         permission: 'FileSystemWrite',
07:42:36     
07:42:36         resource: '\\\\?\\d:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\fixtures\\permission\\deny\\protected-file.md'
07:42:36     
07:42:36       },
07:42:36     
07:42:36       operator: 'throws'
07:42:36     
07:42:36     }
07:42:36     
07:42:36     
07:42:36     
07:42:36     Node.js v20.18.3-pre
07:42:36     
07:42:36     
07:42:36     
07:42:36     1 !== 0
07:42:36     
07:42:36         at Object.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-permission-fs-write.js:44:10)
07:42:36         at Module._compile (node:internal/modules/cjs/loader:1469:14)
07:42:36         at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
07:42:36         at Module.load (node:internal/modules/cjs/loader:1288:32)
07:42:36         at Module._load (node:internal/modules/cjs/loader:1104:12)
07:42:36         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:12)
07:42:36         at node:internal/main/run_main_module:28:49 {
07:42:36       generatedMessage: false,
07:42:36       code: 'ERR_ASSERTION',
07:42:36       actual: 1,
07:42:36       expected: 0,
07:42:36       operator: 'strictEqual'
07:42:36     }
07:42:36     
07:42:36     Node.js v20.18.3-pre

nodejs-github-bot · 2025-01-25T13:14:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64743/

RafaelGSS · 2025-01-25T20:55:24Z

@marco-ippolito I'll fix it Monday. Sorry about it.

nodejs-github-bot · 2025-01-27T14:30:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64767/

marco-ippolito · 2025-01-27T14:30:15Z

maybe its just flaky nodejs/reliability#1096, but It seems very hard to get a green ci 😭

nodejs-github-bot · 2025-01-29T17:57:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64829/

nodejs-github-bot · 2025-01-30T05:39:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64835/

nodejs-github-bot · 2025-01-30T09:55:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64836/

marco-ippolito · 2025-01-30T13:13:09Z

Ci is extremely flaky 😭😭😭😭

nodejs-github-bot · 2025-01-30T13:15:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64840/

marco-ippolito · 2025-01-30T15:55:57Z

@nodejs/build osx is constantly failing or unstable

14:59:33 not ok 4145 sequential/test-http-server-request-timeouts-mixed
14:59:33 ---
14:59:33 duration_ms: 3206.13500
14:59:33 severity: fail
14:59:33 exitcode: 1
14:59:33 stack: |-
14:59:33 node:internal/assert/utils:281
14:59:33 throw err;
14:59:33 ^
14:59:33
14:59:33 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
14:59:33
14:59:33 assert(request2.completed)
14:59:33
14:59:33 at Timeout._onTimeout (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/sequential/test-http-server-request-timeouts-mixed.js:108:5)
14:59:33 at listOnTimeout (node:internal/timers:581:17)
14:59:33 at process.processTimers (node:internal/timers:519:7) {
14:59:33 generatedMessage: true,
14:59:33 code: 'ERR_ASSERTION',
14:59:35 actual: false,
14:59:35 expected: true,
14:59:35 operator: '=='
14:59:35 }
14:59:35
14:59:35 Node.js v20.18.3-pre

richardlau · 2025-01-30T16:04:28Z

osx is constantly failing or unstable

14:59:33 not ok 4145 sequential/test-http-server-request-timeouts-mixed

#43465. Test was marked flaky on macOS in #56503 (which isn't in a release yet but is in the proposal for Node.js 23.7.0). I'd have no objections to pulling in "mark test as flaky" PRs that haven't gone out in current releases if it helps stabilize the CI situation.

marco-ippolito · 2025-01-30T16:06:01Z

osx is constantly failing or unstable
14:59:33 not ok 4145 sequential/test-http-server-request-timeouts-mixed

#43465. Test was marked flaky on macOS in #56503 (which isn't in a release yet but is in the proposal for Node.js 23.7.0). I'd have no objections to pulling in "mark test as flaky" PRs that haven't gone out in current releases if it helps stabilize the CI situation.

I'll cherry-pick it

nodejs-github-bot · 2025-01-30T16:24:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64849/

nodejs-github-bot · 2025-01-31T01:48:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64863/

marco-ippolito · 2025-01-31T08:39:00Z

Finally a green CI

PR-URL: #56727 Refs: #56726 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

marco-ippolito · 2025-01-31T09:20:26Z

Landed in 1c8b474

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 23, 2025

marco-ippolito changed the title ~~test: mark test-buffer-tostring-range as flaky~~ test: mark test-buffer-tostring-range as flaky Jan 23, 2025

marco-ippolito mentioned this pull request Jan 23, 2025

v20.18.3 proposal #56699

Merged

marco-ippolito added lts-watch-v20.x PRs that may need to be released in v20.x request-ci Add this label to start a Jenkins CI on a PR. labels Jan 23, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025

aduh95 approved these changes Jan 23, 2025

View reviewed changes

joyeecheung approved these changes Jan 23, 2025

View reviewed changes

marco-ippolito force-pushed the fix/smart-os branch from 2588b7d to fd49394 Compare January 23, 2025 14:45

marco-ippolito requested a review from a team as a code owner January 23, 2025 14:45

marco-ippolito changed the base branch from main to v20.x-staging January 23, 2025 14:45

marco-ippolito force-pushed the fix/smart-os branch from fd49394 to a7bc6cc Compare January 23, 2025 14:49

marco-ippolito changed the title ~~test: mark test-buffer-tostring-range as flaky~~ [v20.x] test: mark test-buffer-tostring-range as flaky Jan 23, 2025

marco-ippolito added v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Jan 23, 2025

marco-ippolito force-pushed the fix/smart-os branch from a7bc6cc to cc3ca7a Compare January 23, 2025 14:51

aduh95 reviewed Jan 23, 2025

View reviewed changes

test/parallel/parallel.status Outdated Show resolved Hide resolved

aduh95 mentioned this pull request Jan 23, 2025

[v20.x] backport unflagging of require(esm), part 1 (of 4?) #56730

Closed

joyeecheung approved these changes Jan 23, 2025

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025

marco-ippolito force-pushed the v20.x-staging branch from 416c658 to cc7d1a7 Compare January 23, 2025 15:37

marco-ippolito force-pushed the fix/smart-os branch from 315bb71 to f4ac0e1 Compare January 23, 2025 15:39

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2025

marco-ippolito mentioned this pull request Jan 27, 2025

test: temporary remove resource check from fs read-write #56789

Merged

marco-ippolito force-pushed the fix/smart-os branch from f487855 to b5d87d0 Compare January 29, 2025 17:50

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025

test: skip test-buffer-tostring-range on smartos

3b08598

marco-ippolito force-pushed the fix/smart-os branch from b5d87d0 to 3b08598 Compare January 30, 2025 16:07

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2025

marco-ippolito closed this Jan 31, 2025

Uh oh!

Conversation

marco-ippolito commented Jan 23, 2025 • edited by richardlau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpinca commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 23, 2025

Uh oh!

codecov bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marco-ippolito commented Jan 23, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 23, 2025

Uh oh!

nodejs-github-bot commented Jan 25, 2025

Uh oh!

marco-ippolito commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 25, 2025

Uh oh!

RafaelGSS commented Jan 25, 2025

Uh oh!

nodejs-github-bot commented Jan 27, 2025

Uh oh!

marco-ippolito commented Jan 27, 2025

Uh oh!

nodejs-github-bot commented Jan 29, 2025

Uh oh!

nodejs-github-bot commented Jan 30, 2025

Uh oh!

nodejs-github-bot commented Jan 30, 2025

Uh oh!

marco-ippolito commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 30, 2025

Uh oh!

marco-ippolito commented Jan 30, 2025

Uh oh!

richardlau commented Jan 30, 2025

Uh oh!

marco-ippolito commented Jan 30, 2025

Uh oh!

nodejs-github-bot commented Jan 30, 2025

Uh oh!

nodejs-github-bot commented Jan 31, 2025

Uh oh!

marco-ippolito commented Jan 31, 2025

Uh oh!

marco-ippolito commented Jan 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

marco-ippolito commented Jan 23, 2025 •

edited by richardlau

Loading

lpinca commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading

joyeecheung commented Jan 23, 2025 •

edited

Loading

marco-ippolito commented Jan 25, 2025 •

edited

Loading

marco-ippolito commented Jan 30, 2025 •

edited

Loading