Refactor mac installer (built on #2571) by rvagg · Pull Request #5656 · nodejs/node

rvagg · 2016-03-11T07:32:35Z

I've spent some more quality time with Packages today, trying to wrangle this into something closer to ready. Building on the work of @remixz work in #776 and @fhemberger's work in #2571.

Remove the uninstall option - while I got it to work nicely and cleaned up the script to fully remove everything, the installer that Packages makes is not really suitable for an uninstall option, it still says it's "installing", the button is "install", the summary at the end still says it's installed Node & npm, it's basically a hack to make an uninstaller possible. We should consider putting this option on the wiki or even installing it somewhere in /usr/local/ that's not in PATH but we can point users to so they can run it themselves.
Switched to the new logo using the commit on master already
Made the "Install Node.js" option mandatory, Packages has some depend-on functionality for selecting options but there is no way to make it so you have to have Node.js if you select npm, you can make the select box turn on but you can turn it off.
Changed install.py to add new NODE_INSTALL_NODE_ONLY, NODE_INSTALL_NPM_ONLY and NODE_INSTALL_HEADERS_ONLY (was HEADERS_ONLY) env vars so it can install npm to a different location to node so that the options work properly and you can actually opt to not install npm (yes, it works now!).
Made it so you have to click "Customize" to get to the checkboxes to optionally install npm.
Made the LICENSE an RTF, it looks so so much nicer now that it's formatted.
Moved the .pkg to the top-level instead of out/, which is what the current installer does and what Jenkins expects.

Commits are all over the place and need to be compacted obviously.

Will post a test build soon, got to sort out the slaves again.

Fishrock123 · 2016-03-11T17:29:31Z

Makefile

Fishrock123 · 2016-03-11T17:45:55Z

As a note, I got a few whitespace errors when applying.

rvagg · 2016-03-16T07:11:01Z

OK, some more adjustments and I've put Packages on both OSX build machines now (was only on one before). Now I have a test package to share! Grab it at https://nodejs.org/download/test/v6.0.0-test20160316798c9dc5b3/node-v6.0.0-test20160316798c9dc5b3.pkg to experience the new goodness.

eljefedelrodeodeljefe · 2016-05-24T21:48:40Z

Looks reasonable to me. Build worked like a charm. thanks @fhemberger for pointing at this one (have missed it)

This reverts commit d413378.

This refactors the Mac .pkg generation to use Packages. This moves io.js away from using the deprecated Package Maker, and allows for easy localization of the installer.

See nodejs#3986

Needs splitting up, headers install bit needs to go with the install.py changes

jasnell · 2017-02-28T23:17:43Z

ping @rvagg

jasnell · 2017-08-24T23:01:22Z

Closing due to lack of forward progress on this.

Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm PR-URL: nodejs#15179 Fixes: nodejs#15012 Refs: nodejs#5656 Refs: nodejs#2571 Refs: nodejs#7097

Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179 Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: nodejs/node#15179 Fixes: nodejs/node#15012 Refs: nodejs/node#5656 Refs: nodejs/node#2571 Refs: nodejs/node#7097 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179 Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

mscdex added install Issues and PRs related to the installers. macos Issues and PRs related to the macOS platform / OSX. labels Mar 11, 2016

Fishrock123 reviewed Mar 11, 2016
View reviewed changes

Makefile Outdated

Copy link

Contributor

Fishrock123 Mar 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ?=?

fhemberger mentioned this pull request Mar 12, 2016

Translate installers for OS X and Windows #819

Closed

rvagg mentioned this pull request Mar 16, 2016

tools: allow separate component install w/ env var #5734

Closed

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

fhemberger mentioned this pull request May 24, 2016

Refactor mac installer (Rebase of #776 against master) #2571

Closed

MylesBorins mentioned this pull request May 27, 2016

Error: Cannot find module './lib' #3606

Closed

rvagg and others added 17 commits June 8, 2016 16:32

Revert "test: change duration_ms to duration"

553dec2

This reverts commit d413378.

Refactor Mac .pkg generation

12bccda

This refactors the Mac .pkg generation to use Packages. This moves io.js away from using the deprecated Package Maker, and allows for easy localization of the installer.

Add symlink step to Mac installer

0ed035d

Create empty files on pre-pkg, set up uninstall

86c5357

Wrap osx-pkg README at 80 characters

5559798

Add uninstaller

69cfb04

Remove node_modules if folder is empty

453c0ad

Replace iojs -> nodejs, remove symlink

1db12f4

build: Update OS X installer logo

8027c2e

Rename package: nodejs-* -> node-*

a828c74

Add npm preinstall script

d876918

See nodejs#3986

Move .pkg to top-level

6c673b6

build: separate node, npm, headers install options

6f17f1e

build: fix osx uninstaller script

fe8c6c7

build: fix npm in pkg config

bee2989

Use new separate installer directories for pkg

ed5d909

Needs splitting up, headers install bit needs to go with the install.py changes

remove uninstaller

1ac41d9

rvagg force-pushed the master branch from c133999 to 83c7a88 Compare October 18, 2016 17:01

MylesBorins force-pushed the master branch from 8df7ee0 to 54fef67 Compare February 1, 2017 01:00

jasnell added the stalled Issues and PRs that are stalled. label Feb 28, 2017

refack force-pushed the master branch from 16073c0 to fbe946b Compare April 14, 2017 04:11

lance mentioned this pull request Aug 24, 2017

macOS node packages missing version attribute #15012

Closed

jasnell closed this Aug 24, 2017

jpwesselink mentioned this pull request Sep 4, 2017

tools, build: macOS installer improvements #15179

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor mac installer (built on #2571)#5656

Refactor mac installer (built on #2571)#5656
rvagg wants to merge 22 commits intonodejs:masterfrom
rvagg:fhemberger-refactor-mac-installer-rebase

rvagg commented Mar 11, 2016

Uh oh!

Fishrock123 Mar 11, 2016

Uh oh!

Fishrock123 commented Mar 11, 2016

Uh oh!

rvagg commented Mar 16, 2016

Uh oh!

eljefedelrodeodeljefe commented May 24, 2016

Uh oh!

jasnell commented Feb 28, 2017

Uh oh!

jasnell commented Aug 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

rvagg commented Mar 11, 2016

Uh oh!

Fishrock123 Mar 11, 2016

Choose a reason for hiding this comment

Uh oh!

Fishrock123 commented Mar 11, 2016

Uh oh!

rvagg commented Mar 16, 2016

Uh oh!

eljefedelrodeodeljefe commented May 24, 2016

Uh oh!

jasnell commented Feb 28, 2017

Uh oh!

jasnell commented Aug 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants