Conversation
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h
|
s/udpate/update/ :) |
shigeki
force-pushed
the
update_openssl_config
branch
from
a12afa6 to
d76834d
Compare
|
@Fishrock123 Oops. Fixed typo. Thanks. |
shigeki
force-pushed
the
update_openssl_config
branch
from
d76834d to
ca8adf0
Compare
|
CI in https://ci.nodejs.org/job/node-test-commit/2505/ is all green. |
|
Strictly speaking, this fix corresponds to semver-major. As discussed in LTS on nodejs/Release#85, I would like to apply this to 5.x. |
|
LGTM for master... Let's add it to the lts-agenda for Monday to discuss. |
|
@indutny Could you review this PR? |
|
LGTM, if CI is green |
|
@indutny Thanks. CI was submitted in https://ci.nodejs.org/job/node-test-pull-request/1927/. |
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
CI is all green. Landed in 668fb17. Thanks. |
|
Sounds good! :-) |
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
@shigeki is this pressing enough to roll into the next v4 release asap or should it have a bit of time to live on v5 first? |
|
@thealphanerd This fix is a kind of regular procedures in upgrading openssl and has just a small risk. So it's already enough to roll to v4.x. |
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
5 participants
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
deps: openssl
Description of change
deps/openssl/configwere not updated in the last upgrading. Two new defines of OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h.This disables several ciphers included in EXPORT and LOW. They are also disabled in the default cipher list but I think that applying this to LTS should be discussed in LTS issue. I will open it.
CI is running on https://ci.nodejs.org/job/node-test-commit/2502/ but something Jenkins error was on MacOS. I will try it again.
R: @bnoordhuis